[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Implementation of System tray in QML
From:       "Dmitry Ashkadov" <dmitry.ashkadov () rosalab ! ru>
Date:       2012-10-22 18:51:10
Message-ID: 20121022185110.21788.64287 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106965/
-----------------------------------------------------------

(Updated Oct. 22, 2012, 6:51 p.m.)


Review request for Plasma, Aaron J. Seigo and Marco Martin.


Changes
-------

http://commits.kde.org/kde-workspace/c3e4327bf85a99a2fab67fa693091f8e393d3a=
4d

Custom implementation of dialog has been dropped.


Description
-------

Implementation of GUI part of System tray in QML. All code accessible from =
specified branch of kde-workspace =



Diffs (updated)
-----

  plasma/generic/applets/systemtray/CMakeLists.txt d3ce33b =

  plasma/generic/applets/systemtray/TODO 257fbe4 =

  plasma/generic/applets/systemtray/config.h.in aac3113 =

  plasma/generic/applets/systemtray/core/task.h 31d5949 =

  plasma/generic/applets/systemtray/core/task.cpp 55c9a1a =

  plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml PRE-C=
REATION =

  plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml PRE-C=
REATION =

  plasma/generic/applets/systemtray/package/contents/ui/IconsList.js PRE-CR=
EATION =

  plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml PRE-C=
REATION =

  plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.=
qml PRE-CREATION =

  plasma/generic/applets/systemtray/package/contents/ui/TasksSet.js PRE-CRE=
ATION =

  plasma/generic/applets/systemtray/package/contents/ui/TrayIcon.qml PRE-CR=
EATION =

  plasma/generic/applets/systemtray/package/contents/ui/main.js PRE-CREATIO=
N =

  plasma/generic/applets/systemtray/package/contents/ui/main.qml PRE-CREATI=
ON =

  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
protocol.h aa6050e =

  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
protocol.cpp f4e8424 =

  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
task.h 2847b25 =

  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
task.cpp d4cb309 =

  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
widget.h 0c6daf0 =

  plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
widget.cpp 33cf0b1 =

  plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 4cb5368 =

  plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp 69cd625 =

  plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h 3e8d1=
20 =

  plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp 8c1=
ebba =

  plasma/generic/applets/systemtray/ui/applet.h d6cc509 =

  plasma/generic/applets/systemtray/ui/applet.cpp f3c6d9a =

  plasma/generic/applets/systemtray/ui/compactlayout.h c330cee =

  plasma/generic/applets/systemtray/ui/compactlayout.cpp e8d02ff =

  plasma/generic/applets/systemtray/ui/mouseredirectarea.h PRE-CREATION =

  plasma/generic/applets/systemtray/ui/mouseredirectarea.cpp PRE-CREATION =

  plasma/generic/applets/systemtray/ui/plasmoid.h PRE-CREATION =

  plasma/generic/applets/systemtray/ui/plasmoid.cpp PRE-CREATION =

  plasma/generic/applets/systemtray/ui/taskarea.h 0e73ead =

  plasma/generic/applets/systemtray/ui/taskarea.cpp 4c2d120 =

  plasma/generic/applets/systemtray/ui/taskarea_p.h fc93661 =

  plasma/generic/applets/systemtray/ui/taskspool.h PRE-CREATION =

  plasma/generic/applets/systemtray/ui/taskspool.cpp PRE-CREATION =

  plasma/generic/applets/systemtray/ui/uitask.h PRE-CREATION =

  plasma/generic/applets/systemtray/ui/uitask.cpp PRE-CREATION =

  plasma/generic/applets/systemtray/ui/widgetitem.h PRE-CREATION =

  plasma/generic/applets/systemtray/ui/widgetitem.cpp PRE-CREATION =


Diff: http://git.reviewboard.kde.org/r/106965/diff/


Testing
-------


Screenshots
-----------

Example
  http://git.reviewboard.kde.org/r/106965/s/788/


Thanks,

Dmitry Ashkadov


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106965/">http://git.reviewboard.kde.org/r/106965/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Dmitry Ashkadov.</div>


<p style="color: grey;"><i>Updated Oct. 22, 2012, 6:51 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">http://commits.kde.org/kde-workspace/c3e4327bf85a99a2fab67fa693091f8e393d3a4d


Custom implementation of dialog has been dropped.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implementation of GUI part of System tray in QML. All code accessible \
from specified branch of kde-workspace </pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/systemtray/CMakeLists.txt <span style="color: \
grey">(d3ce33b)</span></li>

 <li>plasma/generic/applets/systemtray/TODO <span style="color: \
grey">(257fbe4)</span></li>

 <li>plasma/generic/applets/systemtray/config.h.in <span style="color: \
grey">(aac3113)</span></li>

 <li>plasma/generic/applets/systemtray/core/task.h <span style="color: \
grey">(31d5949)</span></li>

 <li>plasma/generic/applets/systemtray/core/task.cpp <span style="color: \
grey">(55c9a1a)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/IconsList.js <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/TasksSet.js <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/TrayIcon.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/main.js <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h \
<span style="color: grey">(aa6050e)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp \
<span style="color: grey">(f4e8424)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h \
<span style="color: grey">(2847b25)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
<span style="color: grey">(d4cb309)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.h \
<span style="color: grey">(0c6daf0)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp \
<span style="color: grey">(33cf0b1)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/fdo/fdotask.h <span style="color: \
grey">(4cb5368)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp <span style="color: \
grey">(69cd625)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h <span \
style="color: grey">(3e8d120)</span></li>

 <li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp <span \
style="color: grey">(8c1ebba)</span></li>

 <li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: \
grey">(d6cc509)</span></li>

 <li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: \
grey">(f3c6d9a)</span></li>

 <li>plasma/generic/applets/systemtray/ui/compactlayout.h <span style="color: \
grey">(c330cee)</span></li>

 <li>plasma/generic/applets/systemtray/ui/compactlayout.cpp <span style="color: \
grey">(e8d02ff)</span></li>

 <li>plasma/generic/applets/systemtray/ui/mouseredirectarea.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/mouseredirectarea.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/plasmoid.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/plasmoid.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/taskarea.h <span style="color: \
grey">(0e73ead)</span></li>

 <li>plasma/generic/applets/systemtray/ui/taskarea.cpp <span style="color: \
grey">(4c2d120)</span></li>

 <li>plasma/generic/applets/systemtray/ui/taskarea_p.h <span style="color: \
grey">(fc93661)</span></li>

 <li>plasma/generic/applets/systemtray/ui/taskspool.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/taskspool.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/uitask.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/uitask.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/widgetitem.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/systemtray/ui/widgetitem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106965/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106965/s/788/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/20/systemtray_new_400x100.png" \
style="border: 1px black solid;" alt="Example" /></a>

</div>


  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic