'Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting
From:       "David Edmundson" <kde () davidedmundson ! co ! uk>
Date:       2012-10-21 21:33:59
Message-ID: 20121021213359.22510.3653 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106978/#review20642
-----------------------------------------------------------

There does not seem to be a diff attached.

- David Edmundson

On Oct. 21, 2012, 3:43 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106978/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2012, 3:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The main issue was caused by the fact that asking the tab bar native widget to \
> provide a size hint was giving a different size every time which caused the \
> activity bar to expand or shrink in the presence of another expanding widget (in my \
> case, the taskbar), so this patch decides a size hint from the size of the \
> containment (one third of the width of height depending on the form factor) but the \
> size policy is set to expand when the activity bar is the only widget in the \
> containment. 
> 
> This addresses bug 225078.
> http://bugs.kde.org/show_bug.cgi?id=225078
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/106978/diff/
> 
> 
> Testing
> -------
> 
> 1) Add a panel with an actyivity bar and a task bar
> 2) Add a panel with an activty bar only
> 3) Change activities
> 
> Before this patch, the activity bar in the panel with a task bar shrinks or \
> enlarges with every activity change; while the size of the activity bar in the \
> second panel remains constant. After this patch, the size of the activity bar in \
> both panels remains constant. 
> 
> Thanks,
> 
> David Narváez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106978/">http://git.reviewboard.kde.org/r/106978/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There does not seem to \
be a diff attached.</pre>  <br />

<p>- David</p>

<br />
<p>On October 21st, 2012, 3:43 p.m., David Narváez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated Oct. 21, 2012, 3:43 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The main issue was caused by the fact that asking the tab bar native \
widget to provide a size hint was giving a different size every time which caused the \
activity bar to expand or shrink in the presence of another expanding widget (in my \
case, the taskbar), so this patch decides a size hint from the size of the \
containment (one third of the width of height depending on the form factor) but the \
size policy is set to expand when the activity bar is the only widget in the \
containment.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Add a panel with an actyivity bar and a task bar 2) Add a panel with \
an activty bar only 3) Change activities

Before this patch, the activity bar in the panel with a task bar shrinks or enlarges \
with every activity change; while the size of the activity bar in the second panel \
remains constant. After this patch, the size of the activity bar in both panels \
remains constant.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=225078">225078</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106978/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 