[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: replace old kickoff with kickoff-qml
From:       "Greg T" <yellowcake- () gmx ! net>
Date:       2012-10-21 10:45:00
Message-ID: 20121021104500.19219.83283 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> On Oct. 19, 2012, 7:47 p.m., Richard Stockton wrote:
> > One tiny nit about the appearance of the search bar and "trademark area=
": It is like it was in 4.9, very transparent. Upon first resize, however, =
the background of this area changes into a soft gray -- which IMO, is much =
easier on the eyes and more professional. (I vote to initialize it in the s=
ame way it is painted AFTER a resize).

that's odd. the background shouldn't change in any way on resize


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106448/#review20586
-----------------------------------------------------------


On Oct. 21, 2012, 10:23 a.m., Greg T wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106448/
> -----------------------------------------------------------
> =

> (Updated Oct. 21, 2012, 10:23 a.m.)
> =

> =

> Review request for Plasma and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> I think it's time now to get the new kickoff into master so we can polish=
 it for KDE 4.10. the qml plasmoid is still using the old model code (thoug=
h slightly adjusted). This could cause issues for the c++ menu launcher "si=
mpleapplet"...I'm not using it but actually it doesn't even compile. Probab=
ly would be better to port it to qml as well...opinions?
> =

> The qml code resides in the package dir. It's a pure qml widget with c++ =
model extensions...obviously :)
> =

> Add to Panel/Desktop is still not supported but overall I think we have r=
eached feature parity with kickoff c++
> =

> I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. =
How can we ensure a smooth transition for devs and users?
> =

> =

> Diffs
> -----
> =

>   plasma/desktop/applets/kickoff/CMakeLists.txt e9e288866ecdcfd7aa35c086d=
fe78d4252748995 =

>   plasma/desktop/applets/kickoff/Messages.sh b1fa03bcfd6254de7697a674a379=
19724a0a0965 =

>   plasma/desktop/applets/kickoff/applet/applet.h f3afe734df993a4fad950068=
143d84f9e25dedc8 =

>   plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379e830ea02c702f49=
2eb94bf489d87314e1 =

>   plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION =

>   plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872255956321=
292151cdd82326cdf88c5508 =

>   plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba524255fc=
59c2ff5b58a64edc1c7f0f82e2 =

>   plasma/desktop/applets/kickoff/core/favoritesmodel.h 8ee3e9a9eb16780131=
d59b150b50641e5a03a34c =

>   plasma/desktop/applets/kickoff/core/favoritesmodel.cpp 58c2c5de8defe415=
d64204c795075e16c23e883c =

>   plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe51b6e2da604ba=
6eba96f9e6f3f5935f67 =

>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37588af1ebab3=
31082e2eaccb40a0f8155c =

>   plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp 7e2e64d22e=
9e274ffe3d37fdd0ac2c33a622ea3a =

>   plasma/desktop/applets/kickoff/core/kickoffmodel.cpp 8149cac20ce8ab246d=
8f484ca7567fc6e32d548c =

>   plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION =

>   plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION =

>   plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp f92bca971e0f9=
fcb644cadab6aa39a3e36291c00 =

>   plasma/desktop/applets/kickoff/core/krunnermodel.h 93a8b152a673eb623372=
7a82eefd70739ffc5a0f =

>   plasma/desktop/applets/kickoff/core/krunnermodel.cpp 452ebbe81311f8e3e9=
5b5eda5fb9217344852d06 =

>   plasma/desktop/applets/kickoff/core/leavemodel.h 0676fb9358bdfd5e3cffce=
7eb3a0ea5e4ff70989 =

>   plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559cef7331ac5b37f4=
2ed57c7c9a6668d5d53b =

>   plasma/desktop/applets/kickoff/core/models.h 3332ba9608808b353c32d96c37=
b84ddd82aabddf =

>   plasma/desktop/applets/kickoff/core/models.cpp c787df6e2f2c7c88ff97c64c=
7cd7640cce32365b =

>   plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION =

>   plasma/desktop/applets/kickoff/core/recentapplications.h a0feddca1cebbe=
b556623216bcc6c5c30e13a2a4 =

>   plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e0538958564=
ae690e41791bdb5af76fa2ca9a8f =

>   plasma/desktop/applets/kickoff/core/recentlyusedmodel.h 841eb2b77aee778=
a85c76eafa61d38016f6ade58 =

>   plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp 2762d6d63a7b0=
592a7e87cd99603cc7c418292c5 =

>   plasma/desktop/applets/kickoff/core/systemmodel.h 3d7d6e1e6ebb8f3d14f09=
ff5f2e9c22098f4add2 =

>   plasma/desktop/applets/kickoff/core/systemmodel.cpp 11688a10a03a3cdd6ff=
84bfff65d48bec336afbd =

>   plasma/desktop/applets/kickoff/core/urlitemlauncher.h 26b638fc02f42505e=
29857b5c18736e6778a580e =

>   plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp 75bbfb5a5c6df83=
7e7e56de501156b2ca12ed6d7 =

>   plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml=
 PRE-CREATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml PRE-C=
REATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml PR=
E-CREATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml PRE-=
CREATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml PRE-CRE=
ATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml PRE-C=
REATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml PRE-CREA=
TION =

>   plasma/desktop/applets/kickoff/package/metadata.desktop PRE-CREATION =

>   plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.h PRE-CR=
EATION =

>   plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.cpp PRE-=
CREATION =

>   plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 7d2fb7bd0d92c8=
dcaa31a87ca3fcd0742310e101 =

>   plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18a1c=
ddbd9be58991b35dba69fb60e4416c =

>   plasma/desktop/applets/kickoff/ui/brandingbutton.h 698b34e50372dddc3db9=
425ab2ac639cf90d49b7 =

>   plasma/desktop/applets/kickoff/ui/brandingbutton.cpp 5cd8829b8a6cae1e07=
cbf9bffd3abe77b7f9104e =

>   plasma/desktop/applets/kickoff/ui/contentareacap.h 58b37ec74834eefd9697=
86ec99a5cf25b27baf5c =

>   plasma/desktop/applets/kickoff/ui/contentareacap.cpp 45e0e2052720402451=
ae00bed05f6bb0598ec0b3 =

>   plasma/desktop/applets/kickoff/ui/contextmenufactory.h a4c3017b537aa123=
69b08f7fffb28addcca6bce4 =

>   plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp afa666ac8dfaf6=
c746d165d7d662fab185af4442 =

>   plasma/desktop/applets/kickoff/ui/flipscrollview.h e7eba0939237c686ff1c=
a6c0d4c5a6c924ff26d6 =

>   plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 1d48f5b4562c230db7=
d8b6d8d578e5a09cd9e2c4 =

>   plasma/desktop/applets/kickoff/ui/itemdelegate.h bf79e2cc1f501e7136decf=
a7cd05ea651b109cf6 =

>   plasma/desktop/applets/kickoff/ui/itemdelegate.cpp 3b15dd2e7a6ceaba66e1=
e7da27a811ea8ec31c2f =

>   plasma/desktop/applets/kickoff/ui/launcher.h 2a234c36d6fe320cc8021d0741=
56ba2299158e4f =

>   plasma/desktop/applets/kickoff/ui/launcher.cpp 4425bcc79daff81f2448d19a=
75f3feb69dd57543 =

>   plasma/desktop/applets/kickoff/ui/searchbar.h 60aa9b4b3faaafd5484a36a81=
9b8ac0ed5683a9a =

>   plasma/desktop/applets/kickoff/ui/searchbar.cpp 1af8fa95e3497e50cba629c=
2086a9fb381a166ff =

>   plasma/desktop/applets/kickoff/ui/tabbar.h c9281059d35255902fd6d3ed91c5=
171a44421a51 =

>   plasma/desktop/applets/kickoff/ui/tabbar.cpp 43fe16b723ab2010bd02864a91=
1d2d2c8d106821 =

>   plasma/desktop/applets/kickoff/ui/urlitemview.h 285227a40b71065a0219c33=
293c955df3c5c518b =

>   plasma/desktop/applets/kickoff/ui/urlitemview.cpp 892b85be96695d7d71d44=
94af92dae794cb86d66 =

>   plasma/generic/dataengines/packagekit/CMakeLists.txt PRE-CREATION =

>   plasma/generic/dataengines/packagekit/packagekit.operations PRE-CREATIO=
N =

>   plasma/generic/dataengines/packagekit/packagekitengine.h PRE-CREATION =

>   plasma/generic/dataengines/packagekit/packagekitengine.cpp PRE-CREATION =

>   plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION =

>   plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION =

>   plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION =

>   plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATIO=
N =

>   plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desk=
top PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/106448/diff/
> =

> =

> Testing
> -------
> =

> not too much, surely have to update this diff a couple of times. But you =
can start dropping comments anyway.
> =

> =

> Thanks,
> =

> Greg T
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106448/">http://git.reviewboard.kde.org/r/106448/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 19th, 2012, 7:47 p.m., <b>Richard \
Stockton</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One tiny nit about the appearance of the search bar and &quot;trademark \
area&quot;: It is like it was in 4.9, very transparent. Upon first resize, however, \
the background of this area changes into a soft gray -- which IMO, is much easier on \
the eyes and more professional. (I vote to initialize it in the same way it is \
painted AFTER a resize).</pre>  </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that&#39;s odd. the \
background shouldn&#39;t change in any way on resize</pre> <br />








<p>- Greg</p>


<br />
<p>On October 21st, 2012, 10:23 a.m., Greg T wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Greg T.</div>


<p style="color: grey;"><i>Updated Oct. 21, 2012, 10:23 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think it&#39;s time now to get the new kickoff into master so we can \
polish it for KDE 4.10. the qml plasmoid is still using the old model code (though \
slightly adjusted). This could cause issues for the c++ menu launcher \
&quot;simpleapplet&quot;...I&#39;m not using it but actually it doesn&#39;t even \
compile. Probably would be better to port it to qml as well...opinions?

The qml code resides in the package dir. It&#39;s a pure qml widget with c++ model \
extensions...obviously :)

Add to Panel/Desktop is still not supported but overall I think we have reached \
feature parity with kickoff c++

I&#39;m also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can \
we ensure a smooth transition for devs and users?

</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">not too much, surely have to update this diff a couple of times. But you \
can start dropping comments anyway.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: \
grey">(e9e288866ecdcfd7aa35c086dfe78d4252748995)</span></li>

 <li>plasma/desktop/applets/kickoff/Messages.sh <span style="color: \
grey">(b1fa03bcfd6254de7697a674a37919724a0a0965)</span></li>

 <li>plasma/desktop/applets/kickoff/applet/applet.h <span style="color: \
grey">(f3afe734df993a4fad950068143d84f9e25dedc8)</span></li>

 <li>plasma/desktop/applets/kickoff/applet/applet.cpp <span style="color: \
grey">(a6f7379e830ea02c702f492eb94bf489d87314e1)</span></li>

 <li>plasma/desktop/applets/kickoff/core/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/applicationmodel.h <span style="color: \
grey">(f0f8872255956321292151cdd82326cdf88c5508)</span></li>

 <li>plasma/desktop/applets/kickoff/core/applicationmodel.cpp <span style="color: \
grey">(57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2)</span></li>

 <li>plasma/desktop/applets/kickoff/core/favoritesmodel.h <span style="color: \
grey">(8ee3e9a9eb16780131d59b150b50641e5a03a34c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/favoritesmodel.cpp <span style="color: \
grey">(58c2c5de8defe415d64204c795075e16c23e883c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/itemhandlers.h <span style="color: \
grey">(ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67)</span></li>

 <li>plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: \
grey">(4e83c37588af1ebab331082e2eaccb40a0f8155c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp <span style="color: \
grey">(7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffmodel.cpp <span style="color: \
grey">(8149cac20ce8ab246d8f484ca7567fc6e32d548c)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp <span style="color: \
grey">(f92bca971e0f9fcb644cadab6aa39a3e36291c00)</span></li>

 <li>plasma/desktop/applets/kickoff/core/krunnermodel.h <span style="color: \
grey">(93a8b152a673eb6233727a82eefd70739ffc5a0f)</span></li>

 <li>plasma/desktop/applets/kickoff/core/krunnermodel.cpp <span style="color: \
grey">(452ebbe81311f8e3e95b5eda5fb9217344852d06)</span></li>

 <li>plasma/desktop/applets/kickoff/core/leavemodel.h <span style="color: \
grey">(0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989)</span></li>

 <li>plasma/desktop/applets/kickoff/core/leavemodel.cpp <span style="color: \
grey">(47559cef7331ac5b37f42ed57c7c9a6668d5d53b)</span></li>

 <li>plasma/desktop/applets/kickoff/core/models.h <span style="color: \
grey">(3332ba9608808b353c32d96c37b84ddd82aabddf)</span></li>

 <li>plasma/desktop/applets/kickoff/core/models.cpp <span style="color: \
grey">(c787df6e2f2c7c88ff97c64c7cd7640cce32365b)</span></li>

 <li>plasma/desktop/applets/kickoff/core/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentapplications.h <span style="color: \
grey">(a0feddca1cebbeb556623216bcc6c5c30e13a2a4)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentapplications.cpp <span style="color: \
grey">(3e0538958564ae690e41791bdb5af76fa2ca9a8f)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentlyusedmodel.h <span style="color: \
grey">(841eb2b77aee778a85c76eafa61d38016f6ade58)</span></li>

 <li>plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp <span style="color: \
grey">(2762d6d63a7b0592a7e87cd99603cc7c418292c5)</span></li>

 <li>plasma/desktop/applets/kickoff/core/systemmodel.h <span style="color: \
grey">(3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2)</span></li>

 <li>plasma/desktop/applets/kickoff/core/systemmodel.cpp <span style="color: \
grey">(11688a10a03a3cdd6ff84bfff65d48bec336afbd)</span></li>

 <li>plasma/desktop/applets/kickoff/core/urlitemlauncher.h <span style="color: \
grey">(26b638fc02f42505e29857b5c18736e6778a580e)</span></li>

 <li>plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp <span style="color: \
grey">(75bbfb5a5c6df837e7e56de501156b2ca12ed6d7)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.h <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp <span style="color: \
grey">(7d2fb7bd0d92c8dcaa31a87ca3fcd0742310e101)</span></li>

 <li>plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <span style="color: \
grey">(28fba18a1cddbd9be58991b35dba69fb60e4416c)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/brandingbutton.h <span style="color: \
grey">(698b34e50372dddc3db9425ab2ac639cf90d49b7)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/brandingbutton.cpp <span style="color: \
grey">(5cd8829b8a6cae1e07cbf9bffd3abe77b7f9104e)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/contentareacap.h <span style="color: \
grey">(58b37ec74834eefd969786ec99a5cf25b27baf5c)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/contentareacap.cpp <span style="color: \
grey">(45e0e2052720402451ae00bed05f6bb0598ec0b3)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/contextmenufactory.h <span style="color: \
grey">(a4c3017b537aa12369b08f7fffb28addcca6bce4)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <span style="color: \
grey">(afa666ac8dfaf6c746d165d7d662fab185af4442)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/flipscrollview.h <span style="color: \
grey">(e7eba0939237c686ff1ca6c0d4c5a6c924ff26d6)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/flipscrollview.cpp <span style="color: \
grey">(1d48f5b4562c230db7d8b6d8d578e5a09cd9e2c4)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/itemdelegate.h <span style="color: \
grey">(bf79e2cc1f501e7136decfa7cd05ea651b109cf6)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/itemdelegate.cpp <span style="color: \
grey">(3b15dd2e7a6ceaba66e1e7da27a811ea8ec31c2f)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/launcher.h <span style="color: \
grey">(2a234c36d6fe320cc8021d074156ba2299158e4f)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/launcher.cpp <span style="color: \
grey">(4425bcc79daff81f2448d19a75f3feb69dd57543)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/searchbar.h <span style="color: \
grey">(60aa9b4b3faaafd5484a36a819b8ac0ed5683a9a)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/searchbar.cpp <span style="color: \
grey">(1af8fa95e3497e50cba629c2086a9fb381a166ff)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/tabbar.h <span style="color: \
grey">(c9281059d35255902fd6d3ed91c5171a44421a51)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/tabbar.cpp <span style="color: \
grey">(43fe16b723ab2010bd02864a911d2d2c8d106821)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/urlitemview.h <span style="color: \
grey">(285227a40b71065a0219c33293c955df3c5c518b)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/urlitemview.cpp <span style="color: \
grey">(892b85be96695d7d71d4494af92dae794cb86d66)</span></li>

 <li>plasma/generic/dataengines/packagekit/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekit.operations <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitengine.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitengine.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitservice.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/packagekitservice.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106448/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic