'Re: Review Request: make qmlwallpaper thumbnail size similar to other plugins(image, color or patter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: make qmlwallpaper thumbnail size similar to other plugins(image, color or patter
From:       "Commit Hook" <null () kde ! org>
Date:       2012-10-19 10:53:15
Message-ID: 20121019105315.9699.99376 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106927/#review20571
-----------------------------------------------------------

This review has been submitted with commit e02fdaa87258007aa30258c301202e68=
1aea89ac by Reza Shah to branch master.

- Commit Hook

On Oct. 17, 2012, 1 p.m., Reza Shah wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106927/
> -----------------------------------------------------------
> =

> (Updated Oct. 17, 2012, 1 p.m.)
> =

> =

> Review request for Plasma and Aleix Pol Gonzalez.
> =

> =

> Description
> -------
> =

> this patch will make the thumbnail size in qmlwallpaper config dialog sim=
ilar to other plugins such as image, color or pattern plugins.
> =

> =

> Diffs
> -----
> =

>   wallpapers/qmlwallpapers/wallpapersmodel.h 9cd1d5e =

>   wallpapers/qmlwallpapers/wallpapersmodel.cpp b29e511 =

>   wallpapers/qmlwallpapers/wallpapersqml.cpp a737027 =

> =

> Diff: http://git.reviewboard.kde.org/r/106927/diff/
> =

> =

> Testing
> -------
> =

> tested against master
> =

> =

> Thanks,
> =

> Reza Shah
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106927/">http://git.reviewboard.kde.org/r/106927/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e02fdaa87258007aa30258c301202e681aea89ac by Reza Shah to branch \
master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On October 17th, 2012, 1 p.m., Reza Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aleix Pol Gonzalez.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated Oct. 17, 2012, 1 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this patch will make the thumbnail size in qmlwallpaper config dialog \
similar to other plugins such as image, color or pattern plugins.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against master</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>wallpapers/qmlwallpapers/wallpapersmodel.h <span style="color: \
grey">(9cd1d5e)</span></li>

 <li>wallpapers/qmlwallpapers/wallpapersmodel.cpp <span style="color: \
grey">(b29e511)</span></li>

 <li>wallpapers/qmlwallpapers/wallpapersqml.cpp <span style="color: \
grey">(a737027)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106927/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 