[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: populate the settings of the rssnow-qml plasmoid
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-10-18 12:02:49
Message-ID: 20121018120249.6324.93298 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106582/#review20548
-----------------------------------------------------------
rssnow/plasma-applet-rssnow2.desktop
<http://git.reviewboard.kde.org/r/106582/#comment16232>
should be called just rssnow
rssnow/plasma-applet-rssnow2.desktop
<http://git.reviewboard.kde.org/r/106582/#comment16233>
library and plugin name should just overwrite the old rssnow
- Marco Martin
On Sept. 26, 2012, 3:23 p.m., Giorgos Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106582/
> -----------------------------------------------------------
> =
> (Updated Sept. 26, 2012, 3:23 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> I have populated the settings of the rssnow-qml plasmoid
> and they are identical to the ones of the c++ one.
> =
> In order to do that I made the rssnow-qml plasmoid into a hybrid.
> =
> After submit of this review I believe that it is ready to be
> moved into the kdeplasma-addons and to remove the c++ one.
> (I would prefer to open a new review for the move)
> =
> Also I have pushed the latest changes(this diff) into the
> terietor/rssnow/settings branch in declarative-plasmoids
> =
> =
> Diffs
> -----
> =
> rssnow/CMakeLists.txt 79b3581 =
> rssnow/feedsConfig.ui PRE-CREATION =
> rssnow/generalConfig.ui PRE-CREATION =
> rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION =
> rssnow/package/contents/ui/ListItemEntry.qml 657b14b =
> rssnow/package/contents/ui/config.ui e1e3409 =
> rssnow/package/contents/ui/main.qml a575c29 =
> rssnow/plasma-applet-rssnow2.desktop PRE-CREATION =
> rssnow/rssnow.h PRE-CREATION =
> rssnow/rssnow.cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106582/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106582/">http://git.reviewboard.kde.org/r/106582/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106582/diff/1/?file=87282#file87282line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">rssnow/plasma-applet-rssnow2.desktop</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Name=RSSNOW-terietor2</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
called just rssnow</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106582/diff/1/?file=87282#file87282line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">rssnow/plasma-applet-rssnow2.desktop</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">118</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">X-KDE-PluginInfo-Name=rssnow2</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">library and \
plugin name should just overwrite the old rssnow</pre> </div>
<br />
<p>- Marco</p>
<br />
<p>On September 26th, 2012, 3:23 p.m., Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2012, 3:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have populated the settings of the rssnow-qml plasmoid and they are \
identical to the ones of the c++ one.
In order to do that I made the rssnow-qml plasmoid into a hybrid.
After submit of this review I believe that it is ready to be
moved into the kdeplasma-addons and to remove the c++ one.
(I would prefer to open a new review for the move)
Also I have pushed the latest changes(this diff) into the
terietor/rssnow/settings branch in declarative-plasmoids</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>rssnow/CMakeLists.txt <span style="color: grey">(79b3581)</span></li>
<li>rssnow/feedsConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>rssnow/generalConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>rssnow/package/contents/ui/DropRssEntry.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>rssnow/package/contents/ui/ListItemEntry.qml <span style="color: \
grey">(657b14b)</span></li>
<li>rssnow/package/contents/ui/config.ui <span style="color: \
grey">(e1e3409)</span></li>
<li>rssnow/package/contents/ui/main.qml <span style="color: \
grey">(a575c29)</span></li>
<li>rssnow/plasma-applet-rssnow2.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>rssnow/rssnow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>rssnow/rssnow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106582/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic