'Review Request: Fix ReferenceErrors in ListItem'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Fix ReferenceErrors in ListItem
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2012-10-18 2:39:58
Message-ID: 20121018023958.23510.63434 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106937/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

    Check if referenced objects are valid
    =

    This kills two ReferenceErrors I'm seeing when using ListItems inside
    VisualItemModels (in this case, there's no view and visual parent
    attached on creation).

Diffs
-----

  plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 =

Diff: http://git.reviewboard.kde.org/r/106937/diff/

Testing
-------

tried the news app and widgetgallery, no regressions seen.

Thanks,

Sebastian K=C3=BCgler

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106937/">http://git.reviewboard.kde.org/r/106937/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Check if referenced objects are valid  
    This kills two ReferenceErrors I&#39;m seeing when using ListItems inside
    VisualItemModels (in this case, there&#39;s no view and visual parent
    attached on creation).
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tried the news app and widgetgallery, no regressions seen.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/plasmacomponents/qml/ListItem.qml <span style="color: \
grey">(e352eb0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106937/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 