'Re: Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect rat'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect rat
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2012-10-07 13:22:02
Message-ID: 20121007132202.20813.36890 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106754/#review20035
-----------------------------------------------------------

plasma/generic/wallpapers/color/backgroundlistmodel.cpp
<http://git.reviewboard.kde.org/r/106754/#comment15868>

    why not scale m_size here?
    =

    m_size.scale(BackgroundDelegate::SCREENSHOT_SIZE, BackgroundDelegate::S=
CREENSHOT_SIZE/1.6);
    =

    vastly simplifies createPixmap below.

plasma/generic/wallpapers/color/backgroundlistmodel.cpp
<http://git.reviewboard.kde.org/r/106754/#comment15867>

    need to check that data() is valid before using it (the entire point of=
 having a weak pointer :). i would do this at the beginning of the method i=
n this case and return an empty pixmap in that case.

- Aaron J. Seigo

On Oct. 7, 2012, 11:33 a.m., Reza Shah wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106754/
> -----------------------------------------------------------
> =

> (Updated Oct. 7, 2012, 11:33 a.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> I tried to make the behavior of the thumbnail to follow image wallpaper.
> The thumbnail will have aspect ratio similar to active screen aspect rati=
o if possible.
> =

> =

> Diffs
> -----
> =

>   plasma/generic/wallpapers/color/CMakeLists.txt 5ad829d =

>   plasma/generic/wallpapers/color/backgroundlistmodel.h 8bec6b4 =

>   plasma/generic/wallpapers/color/backgroundlistmodel.cpp 6fa4682 =

>   plasma/generic/wallpapers/color/color.cpp 05897ba =

> =

> Diff: http://git.reviewboard.kde.org/r/106754/diff/
> =

> =

> Testing
> -------
> =

> Tested using single monitor only but with different resolution.
> I hope somebody with multi monitor setup can test this patch.
> =

> =

> Thanks,
> =

> Reza Shah
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106754/">http://git.reviewboard.kde.org/r/106754/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106754/diff/1/?file=88612#file88612line106" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/wallpapers/color/backgroundlistmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void BackgroundListModel::setWallpaperSize(const QSize&amp; size)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">m_size</span> <span class="o">=</span> <span class="n">QSizeF</span><span \
class="p">(</span><span class="n">size</span><span class="p">);</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why not \
scale m_size here?

m_size.scale(BackgroundDelegate::SCREENSHOT_SIZE, \
BackgroundDelegate::SCREENSHOT_SIZE/1.6);

vastly simplifies createPixmap below.</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106754/diff/1/?file=88612#file88612line119" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/wallpapers/color/backgroundlistmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void BackgroundListModel::setWallpaperSize(const QSize&amp; size)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">m_structureParent</span><span class="p">.</span><span \
class="n">data</span><span class="p">()</span><span class="o">-&gt;</span><span \
class="n">generatePainting</span><span class="p">(</span><span \
class="n">mode</span><span class="p">,</span> <span class="o">&amp;</span><span \
class="n">p</span><span class="p">,</span> <span class="n">scaledPixmap</span><span \
class="p">.</span><span class="n">rect</span><span class="p">(),</span> <span \
class="n">scaledPixmap</span><span class="p">.</span><span class="n">rect</span><span \
class="p">());</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">need to \
check that data() is valid before using it (the entire point of having a weak pointer \
:). i would do this at the beginning of the method in this case and return an empty \
pixmap in that case.</pre> </div>
<br />

<p>- Aaron J.</p>

<br />
<p>On October 7th, 2012, 11:33 a.m., Reza Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated Oct. 7, 2012, 11:33 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tried to make the behavior of the thumbnail to follow image wallpaper. \
The thumbnail will have aspect ratio similar to active screen aspect ratio if \
possible.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested using single monitor only but with different resolution. I hope \
somebody with multi monitor setup can test this patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/wallpapers/color/CMakeLists.txt <span style="color: \
grey">(5ad829d)</span></li>

 <li>plasma/generic/wallpapers/color/backgroundlistmodel.h <span style="color: \
grey">(8bec6b4)</span></li>

 <li>plasma/generic/wallpapers/color/backgroundlistmodel.cpp <span style="color: \
grey">(6fa4682)</span></li>

 <li>plasma/generic/wallpapers/color/color.cpp <span style="color: \
grey">(05897ba)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106754/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 