[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: refactor the package model
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2012-10-05 18:56:15
Message-ID: 20121005185615.9529.16747 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106742/#review19979
-----------------------------------------------------------
plasmate/editors/editpage.cpp
<http://git.reviewboard.kde.org/r/106742/#comment15833>
Should be done line the lines 147-152
plasmate/editors/editpage.cpp
<http://git.reviewboard.kde.org/r/106742/#comment15834>
why empty line?
plasmate/packagemodel.cpp
<http://git.reviewboard.kde.org/r/106742/#comment15832>
Should it be better if you do something like
=
return QFile::exists(m_package->filePath("mainconfigxml");
- Antonis Tsiapaliokas
On Oct. 5, 2012, 4:25 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106742/
> -----------------------------------------------------------
> =
> (Updated Oct. 5, 2012, 4:25 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> This patch refactors the package model making it "smarter",
> =
> so the package model will
> * create only the necessary files and dirs for a package
> * a dir is empty it will be auto deleted
> * the package model shows the description of the files(if it exists) inst=
ead of their names
> * if a main.xml file doesn't exist, the model will have an entry like "Ne=
w Configuration XML",
> the "New..." entry won't be there.
> =
> =
> Diffs
> -----
> =
> plasmate/editors/editpage.h 8cc5fab =
> plasmate/editors/editpage.cpp 91f6bce =
> plasmate/mainwindow.cpp 8e87b7b =
> plasmate/packagemodel.h 43b9df5 =
> plasmate/packagemodel.cpp 67cc0f4 =
> =
> Diff: http://git.reviewboard.kde.org/r/106742/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliwkas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106742/">http://git.reviewboard.kde.org/r/106742/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106742/diff/1/?file=88505#file88505line161" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/editors/editpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
EditPage::findEditor(const QModelIndex &index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">161</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">target</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">path</span> <span \
class="o">+</span> <span class="sc">'/'</span> <span class="o">+</span> <span \
class="s">"main.xml"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be \
done line the lines 147-152</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106742/diff/1/?file=88505#file88505line167" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/editors/editpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
EditPage::findEditor(const QModelIndex &index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">135</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="n">target</span><span class="p">;</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why empty \
line?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106742/diff/1/?file=88508#file88508line296" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/packagemodel.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool PackageModel::mainConfigXmlExists() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">295</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">QFile</span><span \
class="o">::</span><span class="n">exists</span><span class="p">(</span><span \
class="n">m_package</span><span class="o">-></span><span \
class="n">filePath</span><span class="p">(</span><span \
class="s">"mainconfigxml"</span><span class="p">)))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should it \
be better if you do something like
return QFile::exists(m_package->filePath("mainconfigxml");</pre>
</div>
<br />
<p>- Antonis</p>
<br />
<p>On October 5th, 2012, 4:25 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2012, 4:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch refactors the package model making it "smarter",
so the package model will
* create only the necessary files and dirs for a package
* a dir is empty it will be auto deleted
* the package model shows the description of the files(if it exists) instead of their \
names
* if a main.xml file doesn't exist, the model will have an entry like "New \
Configuration XML", the "New..." entry won't be there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/editors/editpage.h <span style="color: grey">(8cc5fab)</span></li>
<li>plasmate/editors/editpage.cpp <span style="color: grey">(91f6bce)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(8e87b7b)</span></li>
<li>plasmate/packagemodel.h <span style="color: grey">(43b9df5)</span></li>
<li>plasmate/packagemodel.cpp <span style="color: grey">(67cc0f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106742/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic