[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Block screen edge activation for fullscreen windows
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-10-05 8:51:22
Message-ID: 20121005085122.16278.95204 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 4, 2012, 3:02 p.m., Martin Gräßlin wrote:
> > After thinking about it some more: I'm most likely not going to push this, but go \
> > for an atom solution as noted by Thomas.
> > That would probably also fix issues for non fullscreen applications which need to \
> > reserve an area of the screen. E.g. Yakuake or Plasma Panels.
> > I keep the review open for the case we don't have a solution till feature freeze \
> > ;-)
>
> Philip Turmel wrote:
> I'm still hoping to create a generic solution per Thomas' request, but spare time \
> has not been plentiful. I *am* a heavy user of screen edges with full-screen VMs \
> and with KRDC, so a default "on" would be a regression for me. I'm using one \
> corner ==> present desktops in 4.9 as I haven't rebased my left/right solution from \
> 4.8.
> If you do push it, please consider leaving the corners as configured.
>
> Kai Uwe Broulik wrote:
> I especially like that I can e.g. still Present Windows out of a virtual machine \
> that runs fullscreen, without the need of pressing the ungrab mouse keystroke.
AS I said before, I truly believe that this default will strongly depend on how we \
decide the user should use our desktop. This is something where will be very hard to \
make everybody happy.
Even if we allow all developers to decide whether to inhibit or not screen edges, we \
will end up with one "Disable disabling screen edges" in each app users complain to.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106722/#review19905
-----------------------------------------------------------
On Oct. 4, 2012, 1:02 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106722/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 1:02 p.m.)
>
>
> Review request for kwin, Plasma and Aurélien Gâteau.
>
>
> Description
> -------
>
> Block screen edge activation for fullscreen windows
>
> If the active client is a fullscreen window, the screenedges on the
> screen the window is on get's blocked for activation.
>
> We have to assume that the window is managing the screenedge itself to
> offer there additional functionality (e.g. a panel) and KWin's screen
> edge functionality would conflict.
>
>
> Diffs
> -----
>
> kwin/screenedge.cpp a1507c3543877477e564bba368feaa31bc44655e
>
> Diff: http://git.reviewboard.kde.org/r/106722/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106722/">http://git.reviewboard.kde.org/r/106722/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 4th, 2012, 3:02 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After thinking about it some more: I'm most likely not going to push \
this, but go for an atom solution as noted by Thomas.
That would probably also fix issues for non fullscreen applications which need to \
reserve an area of the screen. E.g. Yakuake or Plasma Panels.
I keep the review open for the case we don't have a solution till feature freeze \
;-)</pre> </blockquote>
<p>On October 4th, 2012, 6:06 p.m., <b>Philip Turmel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm still hoping to \
create a generic solution per Thomas' request, but spare time has not been \
plentiful. I *am* a heavy user of screen edges with full-screen VMs and with KRDC, \
so a default "on" would be a regression for me. I'm using one corner \
==> present desktops in 4.9 as I haven't rebased my left/right solution from \
4.8.
If you do push it, please consider leaving the corners as configured.</pre>
</blockquote>
<p>On October 4th, 2012, 9:34 p.m., <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I especially like that I \
can e.g. still Present Windows out of a virtual machine that runs fullscreen, without \
the need of pressing the ungrab mouse keystroke.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AS I said before, I \
truly believe that this default will strongly depend on how we decide the user should \
use our desktop. This is something where will be very hard to make everybody happy.
Even if we allow all developers to decide whether to inhibit or not screen edges, we \
will end up with one "Disable disabling screen edges" in each app users \
complain to.
</pre>
<br />
<p>- Alex</p>
<br />
<p>On October 4th, 2012, 1:02 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Aurélien Gâteau.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2012, 1:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Block screen edge activation for fullscreen windows
If the active client is a fullscreen window, the screenedges on the
screen the window is on get's blocked for activation.
We have to assume that the window is managing the screenedge itself to
offer there additional functionality (e.g. a panel) and KWin's screen
edge functionality would conflict.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/screenedge.cpp <span style="color: \
grey">(a1507c3543877477e564bba368feaa31bc44655e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106722/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic