[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: add preview thumbnail at color wallpaper config dialog
From: "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date: 2012-10-02 15:07:24
Message-ID: 20121002150724.32418.90587 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote:
> > plasma/generic/wallpapers/color/itemsview.h, line 1
> > <http://git.reviewboard.kde.org/r/106626/diff/2/?file=88122#file88122line1>
> >
> > Shouldn't the ItemsView be in some kind of common place?
> >
> > I probably should be using it in Animated Wallpapers as well...
>
> Marco Martin wrote:
> that idea struck me as well, but then the question is where.
>
> places are libplasma, where i think is no-no (we should remove things like that as \
> much as we can for plasma2) or plasmagenericshell, but i don't want wallpapers \
> linking to it.
> if those views were already qml it would be massively easier
>
> Aaron J. Seigo wrote:
> i think it's a moot point right now. it is not optimal at all, but in future we'll \
> just have QML wallpapers and then it's a non-issue: we can wrap this in a standard \
> QML component and wallpapers that need further configuration can use it with a \
> model.
I've just "forked" the BackgroundDelegate as well, for the animated wallpapers.
I agree that if we want to move forward to QML we'll eventually dump any of those \
abstractions, but we probably have 5 or 6 BackroundDelegates at the moment.
In any case, QML config dialogs won't be possible until we figure out the styling, \
I'm afraid...
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106626/#review19754
-----------------------------------------------------------
On Oct. 2, 2012, 11:48 a.m., Reza Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106626/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2012, 11:48 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> This is part of my feature plan for 4.10.
>
> Added preview thumbnail at color wallpaper configuration dialog for each background \
> mode, and removed the background mode combobox.
>
>
> Diffs
> -----
>
> plasma/generic/wallpapers/color/CMakeLists.txt 71006ee
> plasma/generic/wallpapers/color/backgrounddelegate.h e69de29
> plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29
> plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29
> plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29
> plasma/generic/wallpapers/color/color.h a477aa9
> plasma/generic/wallpapers/color/color.cpp d696c2d
> plasma/generic/wallpapers/color/config.ui d5bf809
> plasma/generic/wallpapers/color/itemsview.h e69de29
> plasma/generic/wallpapers/color/itemsview.cpp e69de29
>
> Diff: http://git.reviewboard.kde.org/r/106626/diff/
>
>
> Testing
> -------
>
> tested against master, worked fine.
>
>
> Screenshots
> -----------
>
> new config dialog
> http://git.reviewboard.kde.org/r/106626/s/740/
>
>
> Thanks,
>
> Reza Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106626/">http://git.reviewboard.kde.org/r/106626/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 2nd, 2012, 2:20 p.m., <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106626/diff/2/?file=88122#file88122line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/wallpapers/color/itemsview.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">/*</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't the \
ItemsView be in some kind of common place?
I probably should be using it in Animated Wallpapers as well...</pre>
</blockquote>
<p>On October 2nd, 2012, 2:27 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that idea struck me as \
well, but then the question is where.
places are libplasma, where i think is no-no (we should remove things like that as \
much as we can for plasma2) or plasmagenericshell, but i don't want wallpapers \
linking to it.
if those views were already qml it would be massively easier</pre>
</blockquote>
<p>On October 2nd, 2012, 2:32 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think it's a moot \
point right now. it is not optimal at all, but in future we'll just have QML \
wallpapers and then it's a non-issue: we can wrap this in a standard QML \
component and wallpapers that need further configuration can use it with a \
model.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've \
just "forked" the BackgroundDelegate as well, for the animated wallpapers.
I agree that if we want to move forward to QML we'll eventually dump any of those \
abstractions, but we probably have 5 or 6 BackroundDelegates at the moment.
In any case, QML config dialogs won't be possible until we figure out the \
styling, I'm afraid...</pre> <br />
<p>- Aleix</p>
<br />
<p>On October 2nd, 2012, 11:48 a.m., Reza Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2012, 11:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is part of my feature plan for 4.10.
Added preview thumbnail at color wallpaper configuration dialog for each background \
mode, and removed the background mode combobox. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against master, worked fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/wallpapers/color/CMakeLists.txt <span style="color: \
grey">(71006ee)</span></li>
<li>plasma/generic/wallpapers/color/backgrounddelegate.h <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/backgrounddelegate.cpp <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/backgroundlistmodel.h <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/backgroundlistmodel.cpp <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/color.h <span style="color: \
grey">(a477aa9)</span></li>
<li>plasma/generic/wallpapers/color/color.cpp <span style="color: \
grey">(d696c2d)</span></li>
<li>plasma/generic/wallpapers/color/config.ui <span style="color: \
grey">(d5bf809)</span></li>
<li>plasma/generic/wallpapers/color/itemsview.h <span style="color: \
grey">(e69de29)</span></li>
<li>plasma/generic/wallpapers/color/itemsview.cpp <span style="color: \
grey">(e69de29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106626/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106626/s/740/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/colorlistview_400x100.png" \
style="border: 1px black solid;" alt="new config dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic