From kde-panel-devel Wed Sep 26 15:23:47 2012 From: "Giorgos Tsiapaliwkas" Date: Wed, 26 Sep 2012 15:23:47 +0000 To: kde-panel-devel Subject: Review Request: populate the settings of the rssnow-qml plasmoid Message-Id: <20120926152347.28585.26625 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134867304030873 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2512838746713717955==" --===============2512838746713717955== Content-Type: multipart/alternative; boundary="===============7958693130587726664==" --===============7958693130587726664== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106582/ ----------------------------------------------------------- Review request for Plasma. Description ------- I have populated the settings of the rssnow-qml plasmoid and they are identical to the ones of the c++ one. In order to do that I made the rssnow-qml plasmoid into a hybrid. After submit of this review I believe that it is ready to be moved into the kdeplasma-addons and to remove the c++ one. (I would prefer to open a new review for the move) Also I have pushed the latest changes(this diff) into the terietor/rssnow/settings branch in declarative-plasmoids Diffs ----- rssnow/CMakeLists.txt 79b3581 = rssnow/feedsConfig.ui PRE-CREATION = rssnow/generalConfig.ui PRE-CREATION = rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION = rssnow/package/contents/ui/ListItemEntry.qml 657b14b = rssnow/package/contents/ui/config.ui e1e3409 = rssnow/package/contents/ui/main.qml a575c29 = rssnow/plasma-applet-rssnow2.desktop PRE-CREATION = rssnow/rssnow.h PRE-CREATION = rssnow/rssnow.cpp PRE-CREATION = Diff: http://git.reviewboard.kde.org/r/106582/diff/ Testing ------- Thanks, Giorgos Tsiapaliwkas --===============7958693130587726664== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106582/

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Descripti= on 

I have populated the settings of the rssnow-qml plasmoid
and they are identical to the ones of the c++ one.

In order to do that I made the rssnow-qml plasmoid into a hybrid.

After submit of this review I believe that it is ready to be
moved into the kdeplasma-addons and to remove the c++ one.
(I would prefer to open a new review for the move)

Also I have pushed the latest changes(this diff) into the
terietor/rssnow/settings branch in declarative-plasmoids

Diffs=

  • rssnow/CMakeLists.txt (79b3581)
  • rssnow/feedsConfig.ui (PRE-CREATION)
  • rssnow/generalConfig.ui (PRE-CREATION)
  • rssnow/package/contents/ui/DropRssEntry.qml (657b14b)
  • rssnow/package/contents/ui/config.ui (e1e3= 409)
  • rssnow/package/contents/ui/main.qml (a575c= 29)
  • rssnow/plasma-applet-rssnow2.desktop (PRE-= CREATION)
  • rssnow/rssnow.h (PRE-CREATION)
  • rssnow/rssnow.cpp (PRE-CREATION)

View Diff
--===============7958693130587726664==-- --===============2512838746713717955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2512838746713717955==--