[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Move plasma tools into plasmate
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-09-26 9:47:25
Message-ID: 20120926094725.15341.15424 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106580/#review19443
-----------------------------------------------------------
Ship it!
as this generates large diffs, affects multiple repositories simultaneously=
and is just really moving things around, i don't think this is very well s=
uited to reviewboard. it's better discussed on the mailing list and then ju=
st done. in any case, i'm in favour of this. but before it is pushed to mas=
ter, the current code of plasmate needs to be moved into a sub-directory as=
well. this will result in plasmate/plasmate/, and perhaps we should think =
about renaming the repository to plasma-sdk-tools or somesuch at a future p=
oint. in any case, once plasmate sources are in a subdirectory as well, ple=
ase push.
- Aaron J. Seigo
On Sept. 25, 2012, 11:51 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106580/
> -----------------------------------------------------------
> =
> (Updated Sept. 25, 2012, 11:51 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> This patch moves the kde-workspace/plasma/generic/tools into plasmate/ .
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt 9ff1f27 =
> engineexplorer/CMakeLists.txt PRE-CREATION =
> engineexplorer/Messages.sh PRE-CREATION =
> engineexplorer/engineexplorer.h PRE-CREATION =
> engineexplorer/engineexplorer.cpp PRE-CREATION =
> engineexplorer/engineexplorer.ui PRE-CREATION =
> engineexplorer/ktreeviewsearchline.h PRE-CREATION =
> engineexplorer/ktreeviewsearchline.cpp PRE-CREATION =
> engineexplorer/main.cpp PRE-CREATION =
> engineexplorer/serviceviewer.h PRE-CREATION =
> engineexplorer/serviceviewer.cpp PRE-CREATION =
> engineexplorer/serviceviewer.ui PRE-CREATION =
> engineexplorer/titlecombobox.h PRE-CREATION =
> plasmoidviewer/CMakeLists.txt PRE-CREATION =
> plasmoidviewer/Messages.sh PRE-CREATION =
> plasmoidviewer/fullview.h PRE-CREATION =
> plasmoidviewer/fullview.cpp PRE-CREATION =
> plasmoidviewer/main.cpp PRE-CREATION =
> remote-widgets-browser/CMakeLists.txt PRE-CREATION =
> remote-widgets-browser/Messages.sh PRE-CREATION =
> remote-widgets-browser/main.cpp PRE-CREATION =
> remote-widgets-browser/main.qml PRE-CREATION =
> remote-widgets-browser/plasmafiltermodel.h PRE-CREATION =
> remote-widgets-browser/plasmafiltermodel.cpp PRE-CREATION =
> remote-widgets-browser/resources.qrc PRE-CREATION =
> wallpaperviewer/CMakeLists.txt PRE-CREATION =
> wallpaperviewer/Messages.sh PRE-CREATION =
> wallpaperviewer/main.cpp PRE-CREATION =
> wallpaperviewer/wallpaperwidget.h PRE-CREATION =
> wallpaperviewer/wallpaperwidget.cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106580/diff/
> =
> =
> Testing
> -------
> =
> How I made the move,
> =
> I used the git subtree command, like
> =
> cd foo/kde-workspace
> git subtree split -P plasma/generic/tools -b someBranch
> cd foo/plasmate
> git fetch foo/kde-workspace someBranch
> git checkout master =
> git merge FETCH_HEAD
> vi CMakeLists.txt(this is the conflict)
> git add CMakeLists.txt
> git commit(I haven't done it yet)
> git push origin master(I have done it yet)
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliwkas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106580/">http://git.reviewboard.kde.org/r/106580/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as this generates large \
diffs, affects multiple repositories simultaneously and is just really moving things \
around, i don't think this is very well suited to reviewboard. it's better \
discussed on the mailing list and then just done. in any case, i'm in favour of \
this. but before it is pushed to master, the current code of plasmate needs to be \
moved into a sub-directory as well. this will result in plasmate/plasmate/, and \
perhaps we should think about renaming the repository to plasma-sdk-tools or somesuch \
at a future point. in any case, once plasmate sources are in a subdirectory as well, \
please push.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On September 25th, 2012, 11:51 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2012, 11:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch moves the kde-workspace/plasma/generic/tools into plasmate/ . \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">How I made the move,
I used the git subtree command, like
cd foo/kde-workspace
git subtree split -P plasma/generic/tools -b someBranch
cd foo/plasmate
git fetch foo/kde-workspace someBranch
git checkout master
git merge FETCH_HEAD
vi CMakeLists.txt(this is the conflict)
git add CMakeLists.txt
git commit(I haven't done it yet)
git push origin master(I have done it yet)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9ff1f27)</span></li>
<li>engineexplorer/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/engineexplorer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/engineexplorer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/engineexplorer.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/ktreeviewsearchline.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/ktreeviewsearchline.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engineexplorer/serviceviewer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/serviceviewer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/serviceviewer.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>engineexplorer/titlecombobox.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/fullview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/fullview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoidviewer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/plasmafiltermodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/plasmafiltermodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>remote-widgets-browser/resources.qrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/wallpaperwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>wallpaperviewer/wallpaperwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106580/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic