[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper confi
From: "Reza Shah" <rshah0385 () kireihana ! com>
Date: 2012-09-23 2:19:14
Message-ID: 20120923021914.3812.74154 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106536/
-----------------------------------------------------------
(Updated Sept. 23, 2012, 2:19 a.m.)
Review request for Plasma.
Changes
-------
- description updated
- removed attachments
- diff file updated
Description (updated)
-------
This patch add smoothscrolling behaviour to listview in image wallpaper screen,
to improve the behaviour mentioned in this bug: \
https://bugs.kde.org/show_bug.cgi?id=224198
The codes are from knewstuff itemsview class.
Can this also pushed to 4.9 branch?
PS:not sure how to include itemsview.h and itemsview.cpp in diff file, so i just \
added as file attachments.
This addresses bug 224198.
http://bugs.kde.org/show_bug.cgi?id=224198
Diffs (updated)
-----
plasma/generic/wallpapers/image/CMakeLists.txt 2a4c2a3
plasma/generic/wallpapers/image/imageconfig.ui 793f0ea
plasma/generic/wallpapers/image/itemsview.h PRE-CREATION
plasma/generic/wallpapers/image/itemsview.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106536/diff/
Testing
-------
tested against master.
Thanks,
Reza Shah
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106536/">http://git.reviewboard.kde.org/r/106536/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2012, 2:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- description updated
- removed attachments
- diff file updated</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch add smoothscrolling behaviour to listview in image wallpaper \
screen, to improve the behaviour mentioned in this bug: \
https://bugs.kde.org/show_bug.cgi?id=224198
The codes are from knewstuff itemsview class.
Can this also pushed to 4.9 branch?
PS:not sure how to include itemsview.h and itemsview.cpp in diff file, so i just \
added as file attachments.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=224198">224198</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/wallpapers/image/CMakeLists.txt <span style="color: \
grey">(2a4c2a3)</span></li>
<li>plasma/generic/wallpapers/image/imageconfig.ui <span style="color: \
grey">(793f0ea)</span></li>
<li>plasma/generic/wallpapers/image/itemsview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/wallpapers/image/itemsview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106536/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic