[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix setting the size of the calendar of clocks
From: "Commit Hook" <null () kde ! org>
Date: 2012-09-20 13:50:23
Message-ID: 20120920135023.23330.21278 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106441/#review19223
-----------------------------------------------------------
This review has been submitted with commit b45eada25bcd38d355af499a4023dcb4479e4f9d \
by Ralf Jung to branch KDE/4.9.
- Commit Hook
On Sept. 18, 2012, 5:40 p.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106441/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2012, 5:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Currently, the size of the calendar opened when clicking a clock is sometimes set \
> incorrectly, see the bug I linked to this review request. This patch fixes the bug \
> by setting a proper minimal size on the calendar widget and updating the displayed \
> events after configuration changes.
>
> This addresses bug 306762.
> http://bugs.kde.org/show_bug.cgi?id=306762
>
>
> Diffs
> -----
>
> libs/plasmaclock/calendar.cpp 7ea70c2
>
> Diff: http://git.reviewboard.kde.org/r/106441/diff/
>
>
> Testing
> -------
>
> I verified that the bug is fixed - everything behaved as expected.
>
>
> Thanks,
>
> Ralf Jung
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106441/">http://git.reviewboard.kde.org/r/106441/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b45eada25bcd38d355af499a4023dcb4479e4f9d by Ralf Jung to branch \
KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On September 18th, 2012, 5:40 p.m., Ralf Jung wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2012, 5:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the size of the calendar opened when clicking a clock is \
sometimes set incorrectly, see the bug I linked to this review request. This patch \
fixes the bug by setting a proper minimal size on the calendar widget and updating \
the displayed events after configuration changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I verified that the bug is fixed - everything behaved as expected.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306762">306762</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/calendar.cpp <span style="color: grey">(7ea70c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106441/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic