[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make it possible to use Tree models from QML
From: "Commit Hook" <null () kde ! org>
Date: 2012-09-03 23:30:56
Message-ID: 20120903233056.24320.77137 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106272/#review18474
-----------------------------------------------------------
This review has been submitted with commit c44cff20fdf0b2dff83396328eb1a520=
c5400d0f by Aleix Pol to branch master.
- Commit Hook
On Sept. 3, 2012, 4:46 p.m., Aleix Pol Gonzalez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106272/
> -----------------------------------------------------------
> =
> (Updated Sept. 3, 2012, 4:46 p.m.)
> =
> =
> Review request for Plasma, Aur=C3=A9lien G=C3=A2teau and Marco Martin.
> =
> =
> Description
> -------
> =
> This patch adds a component called ListifyModel (yeah, I hate the name to=
o). The idea behind is to expose as a QAbstractListModel any part of a QAbs=
tractItemModel.
> =
> This solves the problem we have in QML given the limitation that ListView=
only displays the first column of the root items. Here we can specify what=
column we want and what root index we want to have.
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/qtextracomponents/CMakeLists.txt 05a1195 =
> plasma/declarativeimports/qtextracomponents/columnproxymodel.h PRE-CREA=
TION =
> plasma/declarativeimports/qtextracomponents/columnproxymodel.cpp PRE-CR=
EATION =
> plasma/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp=
429282e =
> plasma/declarativeimports/qtextracomponents/tests/CMakeLists.txt PRE-CR=
EATION =
> plasma/declarativeimports/qtextracomponents/tests/columnproxymodeltest.=
h PRE-CREATION =
> plasma/declarativeimports/qtextracomponents/tests/columnproxymodeltest.=
cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106272/diff/
> =
> =
> Testing
> -------
> =
> There's a passing unit test, albeit limited.
> I also tested it with a QML example I had with KPeople. If anybody is int=
erested I can provide it too.
> =
> =
> Thanks,
> =
> Aleix Pol Gonzalez
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106272/">http://git.reviewboard.kde.org/r/106272/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c44cff20fdf0b2dff83396328eb1a520c5400d0f by Aleix Pol to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On September 3rd, 2012, 4:46 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aurélien Gâteau and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2012, 4:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a component called ListifyModel (yeah, I hate the name \
too). The idea behind is to expose as a QAbstractListModel any part of a \
QAbstractItemModel.
This solves the problem we have in QML given the limitation that ListView only \
displays the first column of the root items. Here we can specify what column we want \
and what root index we want to have.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There's a passing unit test, albeit limited. I also tested it with a \
QML example I had with KPeople. If anybody is interested I can provide it too.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/qtextracomponents/CMakeLists.txt <span style="color: \
grey">(05a1195)</span></li>
<li>plasma/declarativeimports/qtextracomponents/columnproxymodel.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/columnproxymodel.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp <span \
style="color: grey">(429282e)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/columnproxymodeltest.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106272/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic