From kde-panel-devel  Fri Aug 31 21:42:55 2012
From: Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date: Fri, 31 Aug 2012 21:42:55 +0000
To: kde-panel-devel
Subject: Re: Re: Re: QJSON a mandatory dependency to kde-workspaces?
Message-Id: <3725881.y4hUYk2oTx () martin-desktop>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134644939627299
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============5592600352200760593=="


--===============5592600352200760593==
Content-Type: multipart/signed; boundary="nextPart2436822.EYHhVW3n4b"; micalg="pgp-sha1"; protocol="application/pgp-signature"
Content-Transfer-Encoding: quoted-printable


--nextPart2436822.EYHhVW3n4b
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Friday 31 August 2012 20:24:25 Marco Gulino wrote:
> Thanks, it helped :)
> I just pushed on master, you can see the commit here:
> http://commits.kde.org/kde-workspace/56e9cf6e7a305caba2a38630109c0486=
dc1b9cd
> e
Instead of adding the define manually, you could have defined it in kde=
-
workspace/config-workspace.h.cmake through a #cmakedefine and just incl=
ude=20
config-workspace.h in you c++ file

Cheers
Martin
>=20
> Cheers
> Marco
>=20
> On Fri, Aug 31, 2012 at 9:01 AM, Martin Gr=C3=A4=C3=9Flin <mgraesslin=
@kde.org> wrote:
> > On Friday 31 August 2012 08:48:20 Marco Gulino wrote:
> > > My fault, sorry... I just forgot about that additional dependency=
. I
> >=20
> > think
> >=20
> > > I'll be able to fix it today or tomorrow, by simply disabling chr=
ome
> > > support when QJSON is not found.
> > > Small problem: there is no builtin  CMake script for QJSON, there=
's one
> > > around that works quite fine, however, I've been using it for oth=
er
> >=20
> > project.
> >=20
> > > Should I add this script to kde-workspace? where exactly?
> >=20
> > Yes I think it is needed. I just wanted to move the check and run i=
nto an
> > issue becauase qjson_FOUND is not set.
> >=20
> > I stop then my work on it as it's better to just exclude the Chrome=

> > support.
> > My current patch to kde-workspace is attached, maybe it's a good st=
arting
> > point for you. The FindQJSON.cmake file should go to cmake/modules.=

> >=20
> > Thanks for taking care of it
> >=20
> > Martin
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel

--nextPart2436822.EYHhVW3n4b
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlBBL98ACgkQqVXwidMiVrrfagCgoovXaR/oxpoQ0cIysSkIhOdL
2XwAn0SaF/6gIDFoJ2g1aauBfLBkSm7v
=ZGjk
-----END PGP SIGNATURE-----

--nextPart2436822.EYHhVW3n4b--


--===============5592600352200760593==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============5592600352200760593==--