From kde-panel-devel Fri Aug 31 20:06:50 2012 From: "Shaun Reich" Date: Fri, 31 Aug 2012 20:06:50 +0000 To: kde-panel-devel Subject: Re: Review Request: Pager QML port Message-Id: <20120831200650.2798.68721 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134644670526633 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4865282333572798926==" --===============4865282333572798926== Content-Type: multipart/alternative; boundary="===============1621220529073484128==" --===============1621220529073484128== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 21, 2012, 5:15 p.m., Marco Martin wrote: > > found a small issue: when there is only one desktop, the pager should s= how nothing and be only few pixels wide (effectively "hidden") > = > Marco Martin wrote: > what's the status on this? can it be merged? > = > Luis Gabriel Lima wrote: > I'll upload a new diff soon (today or tomorrow) with a bug fixed and = the hidden feature. > = > Luis Gabriel Lima wrote: > I was looking the pager history and I found this commit: http://quick= git.kde.org/index.php?p=3Dkde-workspace.git&a=3Dcommit&h=3D9bee3f3fbf3f4b91= caf04ede5bfe1d1aec41f66e > Should we really bring this hidden behavior back? > = > Marco Martin wrote: > when semi invisible it should still have some width and react to righ= t clicks, but that revert wasn't good the revert was needed because it was entirely invisible ;-) iow you couldn't click it or anything, it just took up blank space iirc. no= t opposed to being -somewhat- hidden in that mode, as long as it doesn't tu= rn into "where'd the pager go? what's this gap doing here for?" - Shaun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106112/#review17812 ----------------------------------------------------------- On Aug. 30, 2012, 2:30 a.m., Luis Gabriel Lima wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106112/ > ----------------------------------------------------------- > = > (Updated Aug. 30, 2012, 2:30 a.m.) > = > = > Review request for Plasma and Marco Martin. > = > = > Description > ------- > = > This patch contains the QML port of the Pager plasmoid done during the GS= oC 2012. > = > In this port basically I used QML to paint the Pager UI and deal with the= user interaction. = > The geometry calculation of the desktop and window rectangles was kept in= C++ as well as other routines that needs to interact with classes like KWi= ndowSystem, QDbusConnection and so on. > This patch also introduces the PagerModel, a QAIM subclass that holds the= desktop/window geometries and is used by the QML part to fill the UI. > = > = > Diffs > ----- > = > plasma/desktop/applets/pager/CMakeLists.txt 5d80514 = > plasma/desktop/applets/pager/model.h PRE-CREATION = > plasma/desktop/applets/pager/model.cpp PRE-CREATION = > plasma/desktop/applets/pager/package/contents/ui/main.qml PRE-CREATION = > plasma/desktop/applets/pager/package/contents/ui/utils.js PRE-CREATION = > plasma/desktop/applets/pager/package/metadata.desktop PRE-CREATION = > plasma/desktop/applets/pager/pager.h 6c7c045 = > plasma/desktop/applets/pager/pager.cpp 74dc529 = > = > Diff: http://git.reviewboard.kde.org/r/106112/diff/ > = > = > Testing > ------- > = > - Tested inside panels and floating on desktop, sizing works as expected > - Mouse interactions (move windows around, change desktop, etc) > = > = > Screenshots > ----------- > = > = > http://git.reviewboard.kde.org/r/106112/s/691/ > = > http://git.reviewboard.kde.org/r/106112/s/692/ > = > = > Thanks, > = > Luis Gabriel Lima > = > --===============1621220529073484128== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106112/

On August 21st, 2012, 5:15 p.m., Marco Mart= in wrote:

found a s=
mall issue: when there is only one desktop, the pager should show nothing a=
nd be only few pixels wide (effectively "hidden")

On August 27th, 2012, 9:14 a.m., Marco Martin wrote:

what'=
s the status on this? can it be merged?

On August 27th, 2012, 10:59 a.m., Luis Gabriel Lima wrote:

I'll =
upload a new diff soon (today or tomorrow) with a bug fixed and the hidden =
feature.

On August 29th, 2012, 2:20 a.m., Luis Gabriel Lima wrote:

I was loo=
king the pager history and I found this commit: http://quickgit.kde.org/ind=
ex.php?p=3Dkde-workspace.git&a=3Dcommit&h=3D9bee3f3fbf3f4b91caf04ed=
e5bfe1d1aec41f66e
Should we really bring this hidden behavior back?

On August 29th, 2012, 8:07 a.m., Marco Martin wrote:

when semi=
 invisible it should still have some width and react to right clicks, but t=
hat revert wasn't good
the revert =
was needed because it was entirely invisible ;-)
iow you couldn't click it or anything, it just took up blank space iirc=
. not opposed to being -somewhat- hidden in that mode, as long as it doesn&=
#39;t turn into "where'd the pager go? what's this gap doing h=
ere for?"

- Shaun


On August 30th, 2012, 2:30 a.m., Luis Gabriel Lima wrote:

Review request for Plasma and Marco Martin.
By Luis Gabriel Lima.

Updated Aug. 30, 2012, 2:30 a.m.

Descripti= on 

This patch contains the QML port of the Pager plasmoid done =
during the GSoC 2012.

In this port basically I used QML to paint the Pager UI and deal with the u=
ser interaction. =

The geometry calculation of the desktop and window rectangles was kept in C=
++ as well as other routines that needs to interact with classes like KWind=
owSystem, QDbusConnection and so on.
This patch also introduces the PagerModel, a QAIM subclass that holds the d=
esktop/window geometries and is used by the QML part to fill the UI.

Testing <= /h1> 
- Tested inside panels and floating on desktop, sizing works=
 as expected
- Mouse interactions (move windows around, change desktop, etc)

Diffs=

  • plasma/desktop/applets/pager/CMakeLists.txt (PRE-= CREATION)
  • plasma/desktop/applets/pager/model.cpp (PR= E-CREATION)
  • plasma/desktop/applets/pager/package/contents/ui/main.qml (PRE-CREATION)
  • plasma/desktop/applets/pager/package/contents/ui/utils.js (PRE-CREATION)
  • plasma/desktop/applets/pager/package/metadata.desktop (PRE-CREATION)
  • plasma/desktop/applets/pager/pager.h (6c7c= 045)
  • plasma/desktop/applets/pager/pager.cpp (74= dc529)

View Diff

Screensho= ts

3D"" 3D""
--===============1621220529073484128==-- --===============4865282333572798926== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4865282333572798926==--