[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Re: QJSON a mandatory dependency to kde-workspaces?
From:       Marco Gulino <marco.gulino () gmail ! com>
Date:       2012-08-31 18:24:25
Message-ID: CAGe7n9VHN87RMRC9_VZtJ9NsszuWA9Tf3mgqFXX+UyUUGwvKRw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thanks, it helped :)
I just pushed on master, you can see the commit here:
http://commits.kde.org/kde-workspace/56e9cf6e7a305caba2a38630109c0486dc1b9c=
de

Cheers
Marco

On Fri, Aug 31, 2012 at 9:01 AM, Martin Gr=E4=DFlin <mgraesslin@kde.org> wr=
ote:

> On Friday 31 August 2012 08:48:20 Marco Gulino wrote:
> > My fault, sorry... I just forgot about that additional dependency. I
> think
> > I'll be able to fix it today or tomorrow, by simply disabling chrome
> > support when QJSON is not found.
> > Small problem: there is no builtin  CMake script for QJSON, there's one
> > around that works quite fine, however, I've been using it for other
> project.
> > Should I add this script to kde-workspace? where exactly?
> Yes I think it is needed. I just wanted to move the check and run into an
> issue becauase qjson_FOUND is not set.
>
> I stop then my work on it as it's better to just exclude the Chrome
> support.
> My current patch to kde-workspace is attached, maybe it's a good starting
> point for you. The FindQJSON.cmake file should go to cmake/modules.
>
> Thanks for taking care of it
>
> Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>

[Attachment #5 (text/html)]

Thanks, it helped :)<div>I just pushed on master, you can see the commit here: <a \
href="http://commits.kde.org/kde-workspace/56e9cf6e7a305caba2a38630109c0486dc1b9cde">h \
ttp://commits.kde.org/kde-workspace/56e9cf6e7a305caba2a38630109c0486dc1b9cde</a></div>


<div><br></div><div>Cheers</div><div>Marco</div><div><br><div class="gmail_quote">On \
Fri, Aug 31, 2012 at 9:01 AM, Martin Gräßlin <span dir="ltr">&lt;<a \
href="mailto:mgraesslin@kde.org" target="_blank">mgraesslin@kde.org</a>&gt;</span> \
wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="im">On Friday 31 August 2012 08:48:20 Marco \
Gulino wrote:<br> &gt; My fault, sorry... I just forgot about that additional \
dependency. I think<br> &gt; I&#39;ll be able to fix it today or tomorrow, by simply \
disabling chrome<br> &gt; support when QJSON is not found.<br>
&gt; Small problem: there is no builtin  CMake script for QJSON, there&#39;s one<br>
&gt; around that works quite fine, however, I&#39;ve been using it for other \
project.<br> &gt; Should I add this script to kde-workspace? where exactly?<br>
</div>Yes I think it is needed. I just wanted to move the check and run into an<br>
issue becauase qjson_FOUND is not set.<br>
<br>
I stop then my work on it as it&#39;s better to just exclude the Chrome support.<br>
My current patch to kde-workspace is attached, maybe it&#39;s a good starting<br>
point for you. The FindQJSON.cmake file should go to cmake/modules.<br>
<br>
Thanks for taking care of it<br>
<span class="HOEnZb"><font color="#888888"><br>
Martin</font></span><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]