[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make it possible to use Tree models from QML
From: "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date: 2012-08-31 15:45:06
Message-ID: 20120831154506.13072.14609 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106272/
-----------------------------------------------------------
(Updated Aug. 31, 2012, 3:45 p.m.)
Review request for Plasma, Aur=C3=A9lien G=C3=A2teau and Marco Martin.
Changes
-------
emit rootindexchanged, remove warning.
Description
-------
This patch adds a component called ListifyModel (yeah, I hate the name too)=
. The idea behind is to expose as a QAbstractListModel any part of a QAbstr=
actItemModel.
This solves the problem we have in QML given the limitation that ListView o=
nly displays the first column of the root items. Here we can specify what c=
olumn we want and what root index we want to have.
Diffs (updated)
-----
plasma/declarativeimports/qtextracomponents/CMakeLists.txt 05a1195 =
plasma/declarativeimports/qtextracomponents/fullmodelaccess.h PRE-CREATIO=
N =
plasma/declarativeimports/qtextracomponents/fullmodelaccess.cpp PRE-CREAT=
ION =
plasma/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp 4=
29282e =
plasma/declarativeimports/qtextracomponents/tests/CMakeLists.txt PRE-CREA=
TION =
plasma/declarativeimports/qtextracomponents/tests/fullmodelaccesstest.h P=
RE-CREATION =
plasma/declarativeimports/qtextracomponents/tests/fullmodelaccesstest.cpp=
PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/106272/diff/
Testing
-------
There's a passing unit test, albeit limited.
I also tested it with a QML example I had with KPeople. If anybody is inter=
ested I can provide it too.
Thanks,
Aleix Pol Gonzalez
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106272/">http://git.reviewboard.kde.org/r/106272/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aurélien Gâteau and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2012, 3:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">emit rootindexchanged, remove warning.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a component called ListifyModel (yeah, I hate the name \
too). The idea behind is to expose as a QAbstractListModel any part of a \
QAbstractItemModel.
This solves the problem we have in QML given the limitation that ListView only \
displays the first column of the root items. Here we can specify what column we want \
and what root index we want to have.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There's a passing unit test, albeit limited. I also tested it with a \
QML example I had with KPeople. If anybody is interested I can provide it too.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/qtextracomponents/CMakeLists.txt <span style="color: \
grey">(05a1195)</span></li>
<li>plasma/declarativeimports/qtextracomponents/fullmodelaccess.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/fullmodelaccess.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp <span \
style="color: grey">(429282e)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/fullmodelaccesstest.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/qtextracomponents/tests/fullmodelaccesstest.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106272/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic