[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    QJSON a mandatory dependency to kde-workspaces?
From:       Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date:       2012-08-30 19:53:30
Message-ID: 11133320.2T2qKJC2f2 () martin-desktop
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi all,

since 8f0f84d9575812ee1832d7fabb2c8ee1a9058112 kde-workspace depends on QJSON. 
In plasma/generic/runners/bookmarks/CMakeLists.txt there is the following 
check:
find_package(QJSON REQUIRED)

unfortunately the macro_log_feature is not used, so instead of getting a nice 
summary of what is missing one has to search for something like [1].

Now fixing this is easy, but before doing so, I wanted to check whether it is 
really intended to have QJSON as a hard requirement for kde-workspace.

To me this looks like an optional dependency and if not present the bookmarks 
runner is just excluded.

Opinions?

Cheers
Martin

[1] http://paste.kde.org/541982
["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]