--===============5758041840406553854== Content-Type: multipart/alternative; boundary="===============8801513353522145272==" --===============8801513353522145272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/ ----------------------------------------------------------- Review request for kdelibs and Plasma. Description ------- Krunner's spellcheck plugin has been pretty broken since bd291d21f096a714a1= 71e7af3a534ba345ca5659 (about two years ago) because it called Sonnet::Spel= ler::setLanguage every time the spellchecker was invoked, which was (very m= uch) not thread-safe. This patch makes Sonnet::Speller::setLanguage threadsafe by protecting all = access to the internal dict pointer using QReadWriteLock. = A related review request is 106244, which adds more fixes to the spellcheck= feature. This addresses bugs 264779 and 303831. http://bugs.kde.org/show_bug.cgi?id=3D264779 http://bugs.kde.org/show_bug.cgi?id=3D303831 Diffs ----- kdecore/sonnet/speller.cpp b19e74d = Diff: http://git.reviewboard.kde.org/r/106242/diff/ Testing ------- Compiled, installed, used for a week or so, spellchecked a bunch of things. Thanks, Simeon Bird --===============8801513353522145272== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106242/

Review request for kdelibs and Plasma.
By Simeon Bird.

Descripti= on 

Krunner's spellcheck plugin has been pretty broken since=
 bd291d21f096a714a171e7af3a534ba345ca5659 (about two years ago) because it =
called Sonnet::Speller::setLanguage every time the spellchecker was invoked=
, which was (very much) not thread-safe.

This patch makes Sonnet::Speller::setLanguage threadsafe by protecting all =
access to the internal dict pointer using QReadWriteLock. =


A related review request is 106244, which adds more fixes to the spellcheck=
 feature.

Testing <= /h1> 
Compiled, installed, used for a week or so, spellchecked a b=
unch of things.
Bugs: 264779, = 303831

Diffs=

  • kdecore/sonnet/speller.cpp (b19e74d)

View Diff
--===============8801513353522145272==-- --===============5758041840406553854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5758041840406553854==--