[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2012-08-27 16:06:17
Message-ID: 20120827160617.12398.81762 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 4:06 p.m.)
Review request for kwin, Plasma, Sebastian K=C3=BCgler, Martin Gr=C3=A4=C3=
=9Flin, and Giorgos Tsiapaliwkas.
Changes
-------
In this patch i am fixing the issues that they have pointed out by sebas.
@sebas for the hard coded strings, please take a look at my comment bellow..
Description
-------
Hello,
This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being c=
alled.
Also on the toolbar, there is a new action with name "konsole". This action=
is visible only when we are inside to a KWin Script.
All the other packages, have a previewer. So the "konsole" action is locate=
d inside the previewer.
Diffs (updated)
-----
konsole/konsolepreviewer.h 8dd4369 =
konsole/konsolepreviewer.cpp c4f9f8b =
main.cpp 298be51 =
mainwindow.h 8005d26 =
mainwindow.cpp b84da4a =
plasmateui.rc b51884d =
publisher/remoteinstaller/remoteinstaller.cpp a54d453 =
Diff: http://git.reviewboard.kde.org/r/106118/diff/
Testing
-------
Screenshots
-----------
konsole
http://git.reviewboard.kde.org/r/106118/s/693/
Thanks,
Antonis Tsiapaliokas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106118/">http://git.reviewboard.kde.org/r/106118/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and \
Giorgos Tsiapaliwkas.</div> <div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 4:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In this patch i am fixing the issues that they have pointed out by \
sebas.
@sebas for the hard coded strings, please take a look at my comment bellow..</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being \
called. Also on the toolbar, there is a new action with name "konsole". \
This action is visible only when we are inside to a KWin Script. All the other \
packages, have a previewer. So the "konsole" action is located inside the \
previewer.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>konsole/konsolepreviewer.h <span style="color: grey">(8dd4369)</span></li>
<li>konsole/konsolepreviewer.cpp <span style="color: grey">(c4f9f8b)</span></li>
<li>main.cpp <span style="color: grey">(298be51)</span></li>
<li>mainwindow.h <span style="color: grey">(8005d26)</span></li>
<li>mainwindow.cpp <span style="color: grey">(b84da4a)</span></li>
<li>plasmateui.rc <span style="color: grey">(b51884d)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(a54d453)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106118/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106118/s/693/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/22/kwin_script_konsole_previewer_400x100.png" \
style="border: 1px black solid;" alt="konsole" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic