[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)
From: "Greg T" <yellowcake- () gmx ! net>
Date: 2012-08-27 14:51:32
Message-ID: 20120827145132.7055.55672 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 26, 2012, 7:50 a.m., Greg T wrote:
> > besides the points mentioned in review 106125, you have to remember that KDE 4.8 is already \
> > EOL and there will be no more bugfix release (i.e. 4.8.6).
>
> Richard Stockton wrote:
> Yes, but I was asked to put it on the 4.8 tree in case a packager wants to pick it up for a \
> Distro patch, e.g. "4.8.5-19".
> Lamarque Vieira Souza wrote:
> Well, I do not use 4.8x anymore, this patch does not apply to 4.9 so I cannot test it. Would \
> you provide a patch for 4.9 branch?
He already did. See review 106125
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106123/#review18015
-----------------------------------------------------------
On Aug. 22, 2012, 9:06 p.m., Richard Stockton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106123/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2012, 9:06 p.m.)
>
>
> Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin.
>
>
> Description
> -------
>
> Fix for Kickoff-Widget Keyboard Navigation enhancement (review request 104422): Following \
> enhancement, when a 'search' is performed, the UI became unable to move among the views. This \
> patch enables Qt::Key_Tab to (a) enter into the search Results View, where a program may be \
> selected; (b) move back into the search bar TextEdit widget, by pressing Key_Tab twice; and \
> (c) re-expose the other views, by pressing Key_Tab once (highlighting all text within the \
> seearch bar TextEdit widget), and then pressing Key_Delete to empty the TextEdit field. When \
> the textEdit is empty, the flipscrollview (e.g., "Applications") replaces the Search Results \
> View, and the User is back to the Initial State of the Kickoff-Widget GUI.
>
> This addresses bug 297842.
> http://bugs.kde.org/show_bug.cgi?id=297842
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/ui/launcher.cpp 902e121
> plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93
>
> Diff: http://git.reviewboard.kde.org/r/106123/diff/
>
>
> Testing
> -------
>
> 1: search with multiple search results: Tab enters the results view, and arrow keys can \
> choose from multiple results. Key_Enter does run the selected Application. Per above, Key_Tab \
> returns to the search TextEdit, with existing contents pre-selected/Highlighted. 2. search \
> with empty results: arrow keys do nothing. Tab key returns to the search TextEdit, as in Test \
> #1. 3. When search TextEdit contains no text (via Key_Delete when highlighted, or pressing \
> Key_Delete multiple times) the Initial State of the views is restored: (Tab Bar, Serch Bar, \
> and the selected Tab content present and executable. 4. Key_Escape closes the Kickoff UI, \
> without executing a program. 5. Inability to use Up/Down arrows to go between Views is \
> unfortunate, but remains unchanged from before.
>
> Thanks,
>
> Richard Stockton
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106123/">http://git.reviewboard.kde.org/r/106123/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2012, 7:50 a.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">besides the points mentioned in review \
106125, you have to remember that KDE 4.8 is already EOL and there will be no more bugfix \
release (i.e. 4.8.6). </pre> </blockquote>
<p>On August 26th, 2012, 4:45 p.m., <b>Richard Stockton</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Yes, but I was asked to put it on the 4.8 \
tree in case a packager wants to pick it up for a Distro patch, e.g. \
"4.8.5-19".</pre> </blockquote>
<p>On August 27th, 2012, 12:37 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Well, I do not use 4.8x anymore, this patch \
does not apply to 4.9 so I cannot test it. Would you provide a patch for 4.9 branch?</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">He already did. See review 106125</pre> <br \
/>
<p>- Greg</p>
<br />
<p>On August 22nd, 2012, 9:06 p.m., Richard Stockton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin.</div>
<div>By Richard Stockton.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2012, 9:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix for \
Kickoff-Widget Keyboard Navigation enhancement (review request 104422): Following enhancement, \
when a 'search' is performed, the UI became unable to move among the views. This patch \
enables Qt::Key_Tab to (a) enter into the search Results View, where a program may be selected; \
(b) move back into the search bar TextEdit widget, by pressing Key_Tab twice; and (c) re-expose \
the other views, by pressing Key_Tab once (highlighting all text within the seearch bar \
TextEdit widget), and then pressing Key_Delete to empty the TextEdit field. When the textEdit \
is empty, the flipscrollview (e.g., "Applications") replaces the Search Results View, \
and the User is back to the Initial State of the Kickoff-Widget GUI.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1: search with \
multiple search results: Tab enters the results view, and arrow keys can choose from multiple \
results. Key_Enter does run the selected Application. Per above, Key_Tab returns to the search \
TextEdit, with existing contents pre-selected/Highlighted. 2. search with empty results: arrow \
keys do nothing. Tab key returns to the search TextEdit, as in Test #1. 3. When search TextEdit \
contains no text (via Key_Delete when highlighted, or pressing Key_Delete multiple times) the \
Initial State of the views is restored: (Tab Bar, Serch Bar, and the selected Tab content \
present and executable. 4. Key_Escape closes the Kickoff UI, without executing a program.
5. Inability to use Up/Down arrows to go between Views is unfortunate, but remains unchanged \
from before.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=297842">297842</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/ui/launcher.cpp <span style="color: \
grey">(902e121)</span></li>
<li>plasma/desktop/applets/kickoff/ui/searchbar.cpp <span style="color: \
grey">(6937f93)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106123/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic