[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: LCD Weather Station QML port
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2012-08-27 14:31:03
Message-ID: 20120827143103.6110.29946 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote:
> > Compared visually (haven't looked at the code), it looks fantastic. Jus=
t one question - should the new plasmoid also have the "LCD" background? It=
can be seen on the older one, the green-grayish-LCD-like-background, which=
is missing in the new plasmoid. IMHO the background should stay to keep th=
e visual parity.
> =
> Luis Gabriel Lima wrote:
> The LCD background is still there as you can see in the first screens=
hot.
Ah wait, I thought that's "before the port" and "after the port". That's wh=
at you get for naming your screenshots "No name" :P
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106226/#review18079
-----------------------------------------------------------
On Aug. 26, 2012, 8:06 p.m., Luis Gabriel Lima wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106226/
> -----------------------------------------------------------
> =
> (Updated Aug. 26, 2012, 8:06 p.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> This patch is part of the work done in my GSoC 2012 project and contains =
the new version of the LCD Weather Station plasmoid.
> =
> =
> Diffs
> -----
> =
> applets/weatherstation/CMakeLists.txt 748de4a =
> applets/weatherstation/lcd.svgz 7f5f3d3 =
> applets/weatherstation/lcd2.svgz PRE-CREATION =
> applets/weatherstation/lcd_digits.svgz PRE-CREATION =
> applets/weatherstation/package/contents/ui/LCDDigit.qml PRE-CREATION =
> applets/weatherstation/package/contents/ui/LCDDisplay.qml PRE-CREATION =
> applets/weatherstation/package/contents/ui/Wind.qml PRE-CREATION =
> applets/weatherstation/package/contents/ui/main.qml PRE-CREATION =
> applets/weatherstation/package/metadata.desktop PRE-CREATION =
> applets/weatherstation/weather_icons.svgz PRE-CREATION =
> applets/weatherstation/weatherstation.h 6d4ae24 =
> applets/weatherstation/weatherstation.cpp 8ada9c2 =
> applets/weatherstation/wind_arrows.svgz PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106226/diff/
> =
> =
> Testing
> -------
> =
> - Tested inside panels and floating on desktop
> - Tested with various providers and locations
> =
> =
> Screenshots
> -----------
> =
> =
> http://git.reviewboard.kde.org/r/106226/s/701/
> =
> http://git.reviewboard.kde.org/r/106226/s/702/
> =
> =
> Thanks,
> =
> Luis Gabriel Lima
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106226/">http://git.reviewboard.kde.org/r/106226/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2012, 9:14 a.m., <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compared visually (haven't looked at the code), it looks fantastic. \
Just one question - should the new plasmoid also have the "LCD" background? \
It can be seen on the older one, the green-grayish-LCD-like-background, which is \
missing in the new plasmoid. IMHO the background should stay to keep the visual \
parity.</pre> </blockquote>
<p>On August 27th, 2012, 1:54 p.m., <b>Luis Gabriel Lima</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The LCD background is \
still there as you can see in the first screenshot.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah wait, I thought \
that's "before the port" and "after the port". That's \
what you get for naming your screenshots "No name" :P</pre> <br />
<p>- Martin</p>
<br />
<p>On August 26th, 2012, 8:06 p.m., Luis Gabriel Lima wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 8:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is part of the work done in my GSoC 2012 project and contains \
the new version of the LCD Weather Station plasmoid.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Tested inside panels and floating on desktop
- Tested with various providers and locations</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/weatherstation/CMakeLists.txt <span style="color: \
grey">(748de4a)</span></li>
<li>applets/weatherstation/lcd.svgz <span style="color: grey">(7f5f3d3)</span></li>
<li>applets/weatherstation/lcd2.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/lcd_digits.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/LCDDigit.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/LCDDisplay.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/Wind.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/weather_icons.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weatherstation/weatherstation.h <span style="color: \
grey">(6d4ae24)</span></li>
<li>applets/weatherstation/weatherstation.cpp <span style="color: \
grey">(8ada9c2)</span></li>
<li>applets/weatherstation/wind_arrows.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106226/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106226/s/701/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weatherstation1_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/106226/s/702/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weatherstation2_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic