[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Config cleanup on removeActivity
From: Ivan Čukić <ivan.cukic () kde ! org>
Date: 2012-08-27 6:59:56
Message-ID: 20120827065956.32024.58376 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote:
> > Ship It!
> =
> Ivan =C4=8Cuki=C4=87 wrote:
> Which branch is this, since it is not master as specified?
(in master, VD switcher is moved into a separate plugin)
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106097/#review18065
-----------------------------------------------------------
On Aug. 20, 2012, 11:21 a.m., makis marimpis wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106097/
> -----------------------------------------------------------
> =
> (Updated Aug. 20, 2012, 11:21 a.m.)
> =
> =
> Review request for KDE Runtime and Plasma.
> =
> =
> Description
> -------
> =
> Remove the related configuration entry (which holds the current desktop) =
when an activity is removed.
> =
> =
> Diffs
> -----
> =
> src/service/Activities.cpp e7c1a7bfd5415127b804a2af4bb0b920fb2118ac =
> =
> Diff: http://git.reviewboard.kde.org/r/106097/diff/
> =
> =
> Testing
> -------
> =
> Yes
> =
> =
> Thanks,
> =
> makis marimpis
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106097/">http://git.reviewboard.kde.org/r/106097/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 27th, 2012, 12:42 a.m., <b>Lamarque Vieira Souza</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> </blockquote>
<p>On August 27th, 2012, 6:58 a.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Which branch is this, since it is not master \
as specified?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">(in master, VD switcher is moved into a \
separate plugin)</pre> <br />
<p>- Ivan</p>
<br />
<p>On August 20th, 2012, 11:21 a.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Plasma.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 11:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the related \
configuration entry (which holds the current desktop) when an activity is removed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/service/Activities.cpp <span style="color: \
grey">(e7c1a7bfd5415127b804a2af4bb0b920fb2118ac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106097/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic