'Re: Review Request: Weather Forecast QML port'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Weather Forecast QML port
From:       "David Edmundson" <kde () davidedmundson ! co ! uk>
Date:       2012-08-26 21:36:29
Message-ID: 20120826213629.1395.13517 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106225/#review18054
-----------------------------------------------------------

Looks like a very good start. Comments below.

applets/weather/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106225/#comment14295>

    Where do you use this?

applets/weather/package/contents/ui/FiveDaysView.qml
<http://git.reviewboard.kde.org/r/106225/#comment14297>

    What is this doing? Changing the text from inside "color: " isn't very =
intuitive to read. =

    =

    You must be mixing logic and styling which isn't ever advised for maint=
ainable code.
    =

    Needs a comment at least, ideally rewriting.

applets/weather/package/contents/ui/FiveDaysView.qml
<http://git.reviewboard.kde.org/r/106225/#comment14296>

    you don't need this.. just use =

    =

    color: theColour
    alpha: theAlpha
    =

    merging them into a string, just for QML to split it again seems odd.

applets/weather/package/contents/ui/Notice.qml
<http://git.reviewboard.kde.org/r/106225/#comment14298>

    Unless there's a good reason, use PlasmaComponents.Label rather than Te=
xt. Otherwise font size won't be consistent.
    =

    Saves you setting the theme colour yourself too :)
    =

    Same for all instances of Text

applets/weather/package/contents/ui/WeatherListView.qml
<http://git.reviewboard.kde.org/r/106225/#comment14299>

    18 hardcoded? Surely it depends on the size of the text?

applets/weather/weatherapplet.h
<http://git.reviewboard.kde.org/r/106225/#comment14301>

    Having a slot with the same name as a signal is really confusing. You e=
nd up emitting dataUpdated from dataUpdated.
    =

applets/weather/weatherapplet.h
<http://git.reviewboard.kde.org/r/106225/#comment14300>

    You don't need this.
    =

    In your QML you can call plasmoid.openUrl()

- David Edmundson

On Aug. 26, 2012, 7:59 p.m., Luis Gabriel Lima wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106225/
> -----------------------------------------------------------
> =

> (Updated Aug. 26, 2012, 7:59 p.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> This patch is part of the work done in my GSoC 2012 project.
> =

> =

> Diffs
> -----
> =

>   applets/weather/CMakeLists.txt 4ae9c6f =

>   applets/weather/package/contents/ui/DetailsView.qml PRE-CREATION =

>   applets/weather/package/contents/ui/FiveDaysView.qml PRE-CREATION =

>   applets/weather/package/contents/ui/Notice.qml PRE-CREATION =

>   applets/weather/package/contents/ui/NoticesView.qml PRE-CREATION =

>   applets/weather/package/contents/ui/TopPanel.qml PRE-CREATION =

>   applets/weather/package/contents/ui/Utils.js PRE-CREATION =

>   applets/weather/package/contents/ui/WeatherListView.qml PRE-CREATION =

>   applets/weather/package/contents/ui/main.qml PRE-CREATION =

>   applets/weather/package/metadata.desktop PRE-CREATION =

>   applets/weather/weatherapplet.h a7e7f8d =

>   applets/weather/weatherapplet.cpp 9fd3e5f =

>   applets/weather/weatherdelegate.h 8a27f0d =

>   applets/weather/weatherdelegate.cpp 1cd987b =

>   applets/weather/weatherview.h f177501 =

>   applets/weather/weatherview.cpp 5234cd3 =

> =

> Diff: http://git.reviewboard.kde.org/r/106225/diff/
> =

> =

> Testing
> -------
> =

> - Tested inside panels and floating on desktop
> - Tested with various providers and locations
> =

> =

> Screenshots
> -----------
> =

> =

>   http://git.reviewboard.kde.org/r/106225/s/696/
> =

>   http://git.reviewboard.kde.org/r/106225/s/698/
> =

>   http://git.reviewboard.kde.org/r/106225/s/699/
> =

>   http://git.reviewboard.kde.org/r/106225/s/700/
> =

> =

> Thanks,
> =

> Luis Gabriel Lima
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106225/">http://git.reviewboard.kde.org/r/106225/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like a very good \
start. Comments below.</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81338#file81338line15" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">13</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    \
${QT_QTWEBKIT_LIBRARY}</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where do \
you use this?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81340#file81340line65" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/FiveDaysView.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">65</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
var ntIndex = text.indexOf(&quot;nt&quot;);</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is \
this doing? Changing the text from inside &quot;color: &quot; isn&#39;t very \
intuitive to read. 

You must be mixing logic and styling which isn&#39;t ever advised for maintainable \
code.

Needs a comment at least, ideally rewriting.</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81340#file81340line70" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/FiveDaysView.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
return Utils.setAlphaF(theme.textColor, 0.5);</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you \
don&#39;t need this.. just use 

color: theColour
alpha: theAlpha

merging them into a string, just for QML to split it again seems odd.</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81341#file81341line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/Notice.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    Text \
{</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unless \
there&#39;s a good reason, use PlasmaComponents.Label rather than Text. Otherwise \
font size won&#39;t be consistent.

Saves you setting the theme colour yourself too :)

Same for all instances of Text</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81345#file81345line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/WeatherListView.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    property \
int rowHeight: 18</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">18 \
hardcoded? Surely it depends on the size of the text?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81348#file81348line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/weatherapplet.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public \
Q_SLOTS:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">56</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="n">dataUpdated</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">source</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">Plasma</span><span class="o">::</span><span \
class="n">DataEngine</span><span class="o">::</span><span class="n">Data</span> <span \
class="o">&amp;</span><span class="n">data</span><span class="p">);</span></pre></td> \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="n">dataUpdated</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">source</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">Plasma</span><span class="o">::</span><span \
class="n">DataEngine</span><span class="o">::</span><span class="n">Data</span> <span \
class="o">&amp;</span><span class="n">data</span><span class="p">);</span></pre></td> \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Having a \
slot with the same name as a signal is really confusing. You end up emitting \
dataUpdated from dataUpdated. </pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106225/diff/1/?file=81348#file81348line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/weatherapplet.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public \
Q_SLOTS:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">57</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="n">reloadTheme</span><span \
class="p">(</span><span class="kt">void</span><span class="p">);</span></pre></td>  \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="n">invokeBrowser</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span \
class="o">&amp;</span><span class="n">url</span> <span class="o">=</span> <span \
class="n">QString</span><span class="p">())</span> <span class="k">const</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You \
don&#39;t need this.

In your QML you can call plasmoid.openUrl()</pre>
</div>
<br />

<p>- David</p>

<br />
<p>On August 26th, 2012, 7:59 p.m., Luis Gabriel Lima wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>

<p style="color: grey;"><i>Updated Aug. 26, 2012, 7:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is part of the work done in my GSoC 2012 project.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- Tested inside panels and floating on desktop
- Tested with various providers and locations</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/weather/CMakeLists.txt <span style="color: grey">(4ae9c6f)</span></li>

 <li>applets/weather/package/contents/ui/DetailsView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/FiveDaysView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/Notice.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/NoticesView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/TopPanel.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/Utils.js <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/WeatherListView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/weather/weatherapplet.h <span style="color: grey">(a7e7f8d)</span></li>

 <li>applets/weather/weatherapplet.cpp <span style="color: \
grey">(9fd3e5f)</span></li>

 <li>applets/weather/weatherdelegate.h <span style="color: \
grey">(8a27f0d)</span></li>

 <li>applets/weather/weatherdelegate.cpp <span style="color: \
grey">(1cd987b)</span></li>

 <li>applets/weather/weatherview.h <span style="color: grey">(f177501)</span></li>

 <li>applets/weather/weatherview.cpp <span style="color: grey">(5234cd3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106225/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106225/s/696/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather11_400x100.png" \
style="border: 1px black solid;" alt="" /></a>

 <a href="http://git.reviewboard.kde.org/r/106225/s/698/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather12_1_400x100.png" \
style="border: 1px black solid;" alt="" /></a>

 <a href="http://git.reviewboard.kde.org/r/106225/s/699/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather21_400x100.png" \
style="border: 1px black solid;" alt="" /></a>

 <a href="http://git.reviewboard.kde.org/r/106225/s/700/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather22_400x100.png" \
style="border: 1px black solid;" alt="" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 