[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-08-23 22:19:50
Message-ID: 20120823221950.2088.78158 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review17927
-----------------------------------------------------------
konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14158>
Would be useful if the user was told what to do about it (i.e. either give the \
name of the expected file, or explain where you can set the name (and what it should \
be).
mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14155>
I don't really like this deviation in behavior, mainly because I don't see a \
reason for it.
I think the behaviour of opening the konsole from the previewer is not ideal \
anyway, since that's a very unusual way to trigger a change in the main UI. The issue \
you're trying to address here is in the previewer, and access to the console should \
be in the main UI anyway (i.e. menu entry, shortcut, and possibly toolbar action).
mainwindow.cpp
<http://git.reviewboard.kde.org/r/106118/#comment14157>
Seems like a toggle button (checkable) is needed here, instead of trying to come \
up with whacky new concepts of doing the exact same =).
- Sebastian Kügler
On Aug. 22, 2012, 9:34 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2012, 9:34 a.m.)
>
>
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos \
> Tsiapaliwkas.
>
> Description
> -------
>
> Hello,
>
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being called.
> Also on the toolbar, there is a new action with name "konsole". This action is \
> visible only when we are inside to a KWin Script. All the other packages, have a \
> previewer. So the "konsole" action is located inside the previewer.
>
> Diffs
> -----
>
> konsole/konsolepreviewer.h 8dd4369
> konsole/konsolepreviewer.cpp c4f9f8b
> main.cpp 298be51
> mainwindow.h 8005d26
> mainwindow.cpp b84da4a
> plasmateui.rc b51884d
>
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> konsole
> http://git.reviewboard.kde.org/r/106118/s/693/
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106118/">http://git.reviewboard.kde.org/r/106118/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106118/diff/1/?file=79944#file79944line135" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konsole/konsolepreviewer.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void KonsolePreviewer::executeKWinScript()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">135</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_KWinScriptOutput</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"The main source file doesn't \
exist."</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would be \
useful if the user was told what to do about it (i.e. either give the name of the \
expected file, or explain where you can set the name (and what it should be).</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106118/diff/1/?file=79947#file79947line261" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MainWindow::setupActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">261</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">addAction</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Konsole"</span><span class="p">),</span> \
<span class="s">"utilities-terminal"</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span \
class="n">showKonsolePreviewer</span><span class="p">()),</span> <span \
class="s">"konsole"</span><span class="p">)</span><span \
class="o">-></span><span class="n">setVisible</span><span class="p">(</span><span \
class="kc">false</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't \
really like this deviation in behavior, mainly because I don't see a reason for \
it.
I think the behaviour of opening the konsole from the previewer is not ideal anyway, \
since that's a very unusual way to trigger a change in the main UI. The issue \
you're trying to address here is in the previewer, and access to the console \
should be in the main UI anyway (i.e. menu entry, shortcut, and possibly toolbar \
action).</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106118/diff/1/?file=79947#file79947line870" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MainWindow::loadProject(const QString &path)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">866</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//</span><span class="cs">TODO</span><span class="c1">: terietor believes \
that we need this else in order to hide the preview action,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems like \
a toggle button (checkable) is needed here, instead of trying to come up with whacky \
new concepts of doing the exact same =).</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On August 22nd, 2012, 9:34 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and \
Giorgos Tsiapaliwkas.</div> <div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2012, 9:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being \
called. Also on the toolbar, there is a new action with name "konsole". \
This action is visible only when we are inside to a KWin Script. All the other \
packages, have a previewer. So the "konsole" action is located inside the \
previewer.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konsole/konsolepreviewer.h <span style="color: grey">(8dd4369)</span></li>
<li>konsole/konsolepreviewer.cpp <span style="color: grey">(c4f9f8b)</span></li>
<li>main.cpp <span style="color: grey">(298be51)</span></li>
<li>mainwindow.h <span style="color: grey">(8005d26)</span></li>
<li>mainwindow.cpp <span style="color: grey">(b84da4a)</span></li>
<li>plasmateui.rc <span style="color: grey">(b51884d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106118/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106118/s/693/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/22/kwin_script_konsole_previewer_400x100.png" \
style="border: 1px black solid;" alt="konsole" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic