From kde-panel-devel Wed Aug 22 18:44:32 2012 From: "Alexey Shmalko" Date: Wed, 22 Aug 2012 18:44:32 +0000 To: kde-panel-devel Subject: Re: Review Request: Make autohide panel do not intercept events in fullscreen app Message-Id: <20120822184432.17945.62754 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134571865723877 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6566312523536688050==" --===============6566312523536688050== Content-Type: multipart/alternative; boundary="===============7803089154469020393==" --===============7803089154469020393== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/ ----------------------------------------------------------- (Updated Aug. 22, 2012, 6:44 p.m.) Review request for kwin and Plasma. Description ------- Make autohide panel do not intercept events in fullscreen app. I changed PanelView::shouldHintHide() to return true if current active appl= ication is in fullscreen mode. So in fullscreen applications panel will be = always hidden. This addresses bugs 297920 and 305497. http://bugs.kde.org/show_bug.cgi?id=3D297920 http://bugs.kde.org/show_bug.cgi?id=3D305497 Diffs ----- plasma/desktop/shell/panelview.cpp 7713740 = Diff: http://git.reviewboard.kde.org/r/106110/diff/ Testing (updated) ------- Tested with patched gentoo ebuild. Works fine. Thanks, Alexey Shmalko --===============7803089154469020393== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106110/

Review request for kwin and Plasma.

By Alexey Shmalko.

Updated Aug. 22, 2012, 6:44 p.m.

Descripti= on

Make autohide panel do not intercept events in fullscreen ap=
p.

I changed PanelView::shouldHintHide() to return true if current active appl=
ication is in fullscreen mode. So in fullscreen applications panel will be =
always hidden.

Testing (= updated)

Tested with patched gentoo ebuild. Works fine.

Bugs: 297920, = 305497

Diffs=

plasma/desktop/shell/panelview.cpp (771374= 0)

View Diff

--===============7803089154469020393==-- --===============6566312523536688050== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6566312523536688050==--