[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Pager QML port
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-08-21 16:43:27
Message-ID: 20120821164327.24146.3969 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106112/#review17811
-----------------------------------------------------------
Ship it!
i'm using it since a while and all regressions seems fixed, i think is safe=
to merge into master
- Marco Martin
On Aug. 21, 2012, 2:33 a.m., Luis Gabriel Lima wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106112/
> -----------------------------------------------------------
> =
> (Updated Aug. 21, 2012, 2:33 a.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> This patch contains the QML port of the Pager plasmoid done during the GS=
oC 2012.
> =
> In this port basically I used QML to paint the Pager UI and deal with the=
user interaction. =
> The geometry calculation of the desktop and window rectangles was kept in=
C++ as well as other routines that needs to interact with classes like KWi=
ndowSystem, QDbusConnection and so on.
> This patch also introduces the PagerModel, a QAIM subclass that holds the=
desktop/window geometries and is used by the QML part to fill the UI.
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/pager/CMakeLists.txt 5d80514 =
> plasma/desktop/applets/pager/model.h PRE-CREATION =
> plasma/desktop/applets/pager/model.cpp PRE-CREATION =
> plasma/desktop/applets/pager/package/contents/ui/main.qml PRE-CREATION =
> plasma/desktop/applets/pager/package/contents/ui/utils.js PRE-CREATION =
> plasma/desktop/applets/pager/package/metadata.desktop PRE-CREATION =
> plasma/desktop/applets/pager/pager.h 6c7c045 =
> plasma/desktop/applets/pager/pager.cpp 74dc529 =
> =
> Diff: http://git.reviewboard.kde.org/r/106112/diff/
> =
> =
> Testing
> -------
> =
> - Tested inside panels and floating on desktop, sizing works as expected
> - Mouse interactions (move windows around, change desktop, etc)
> =
> =
> Screenshots
> -----------
> =
> =
> http://git.reviewboard.kde.org/r/106112/s/691/
> =
> http://git.reviewboard.kde.org/r/106112/s/692/
> =
> =
> Thanks,
> =
> Luis Gabriel Lima
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106112/">http://git.reviewboard.kde.org/r/106112/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'm using it since a \
while and all regressions seems fixed, i think is safe to merge into master</pre> \
<br />
<p>- Marco</p>
<br />
<p>On August 21st, 2012, 2:33 a.m., Luis Gabriel Lima wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2012, 2:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch contains the QML port of the Pager plasmoid done during the \
GSoC 2012.
In this port basically I used QML to paint the Pager UI and deal with the user \
interaction. The geometry calculation of the desktop and window rectangles was kept \
in C++ as well as other routines that needs to interact with classes like \
KWindowSystem, QDbusConnection and so on. This patch also introduces the PagerModel, \
a QAIM subclass that holds the desktop/window geometries and is used by the QML part \
to fill the UI.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Tested inside panels and floating on desktop, sizing \
works as expected
- Mouse interactions (move windows around, change desktop, etc)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/pager/CMakeLists.txt <span style="color: \
grey">(5d80514)</span></li>
<li>plasma/desktop/applets/pager/model.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/pager/model.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/pager/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/pager/package/contents/ui/utils.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/pager/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/pager/pager.h <span style="color: \
grey">(6c7c045)</span></li>
<li>plasma/desktop/applets/pager/pager.cpp <span style="color: \
grey">(74dc529)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106112/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106112/s/691/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/21/pager_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/106112/s/692/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/21/pager-panel_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic