'Re: Review Request: Make autohide panel do not intercept events in fullscreen app'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Make autohide panel do not intercept events in fullscreen app
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-08-21 4:22:06
Message-ID: 20120821042206.31977.2061 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review17790
-----------------------------------------------------------

I do not see a reason why the hidden panel should not be allowed to go above a \
fullscreen window. True it's not possible for the normal panel case, but hidden panel \
is kind of special.

Apart from that I think you modified the wrong place as it's only about the hint and \
you bound it with whether compositing is used.

- Martin Gräßlin

On Aug. 20, 2012, 6:26 p.m., Alexey Shmalko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 6:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::shouldHintHide() to return true if current active application \
> is in fullscreen mode. So in fullscreen applications panel will be always hidden. 
> 
> This addresses bugs 297920 and 305497.
> http://bugs.kde.org/show_bug.cgi?id=297920
> http://bugs.kde.org/show_bug.cgi?id=305497
> 
> 
> Diffs
> -----
> 
> plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106110/">http://git.reviewboard.kde.org/r/106110/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not see a reason \
why the hidden panel should not be allowed to go above a fullscreen window. True \
it&#39;s not possible for the normal panel case, but hidden panel is kind of special.

Apart from that I think you modified the wrong place as it&#39;s only about the hint \
and you bound it with whether compositing is used.</pre>  <br />

<p>- Martin</p>

<br />
<p>On August 20th, 2012, 6:26 p.m., Alexey Shmalko wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Alexey Shmalko.</div>

<p style="color: grey;"><i>Updated Aug. 20, 2012, 6:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make autohide panel do not intercept events in fullscreen app.

I changed PanelView::shouldHintHide() to return true if current active application is \
in fullscreen mode. So in fullscreen applications panel will be always hidden.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=297920">297920</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=305497">305497</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(7713740)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106110/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 