[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix for Bug 165792 - Allow multirow panels
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-08-18 10:38:20
Message-ID: 20120818103820.4344.97093 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105932/#review17652
-----------------------------------------------------------
I'm quite on the fence with this.
while in theory makes sense being able to stack panels, it's a thing quite hard to \
get reliable, i just see too many problems with it. at least some conditions in the \
behavior should be satisfied:
* should still be possible to position two or more panels on the same line, given \
they don't overlap
* move and resize controls in the panel controller should continue to work reliably
* if two panels are stacked, any change of height of the bottom panel should cause a \
correct repositioning of the top panel
* how does one decide what panel stays at the bottom and what panel gets stacked? \
must be easy to switch them
* if two panels are on the same line because there is enough room, and one of the two \
resizes (by the user or spontaneously) the panels should be relayouted in two lines, \
with a consistent and reproducible decision of who stays on top and who stays on \
bottom
* all the described behavior shouldn't break for more than two lines
plasma/desktop/shell/panelview.cpp
<http://git.reviewboard.kde.org/r/105932/#comment13817>
watch out for empty space and dead code
- Marco Martin
On Aug. 8, 2012, 4:19 p.m., Tobias Franz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105932/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 4:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> goes back to:
> https://bugs.kde.org/show_bug.cgi?id=165792
>
>
> This addresses bug 165792.
> http://bugs.kde.org/show_bug.cgi?id=165792
>
>
> Diffs
> -----
>
> plasma/desktop/shell/panelview.cpp 50826a8
>
> Diff: http://git.reviewboard.kde.org/r/105932/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tobias Franz
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105932/">http://git.reviewboard.kde.org/r/105932/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm quite on the \
fence with this. while in theory makes sense being able to stack panels, it's a \
thing quite hard to get reliable, i just see too many problems with it. at least some \
conditions in the behavior should be satisfied:
* should still be possible to position two or more panels on the same line, given \
they don't overlap
* move and resize controls in the panel controller should continue to work reliably
* if two panels are stacked, any change of height of the bottom panel should cause a \
correct repositioning of the top panel
* how does one decide what panel stays at the bottom and what panel gets stacked? \
must be easy to switch them
* if two panels are on the same line because there is enough room, and one of the two \
resizes (by the user or spontaneously) the panels should be relayouted in two lines, \
with a consistent and reproducible decision of who stays on top and who stays on \
bottom
* all the described behavior shouldn't break for more than two lines</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105932/diff/1/?file=76625#file76625line1083" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/shell/panelview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PanelView::updateStruts()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1082</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="cm">/*</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">watch out \
for empty space and dead code</pre> </div>
<br />
<p>- Marco</p>
<br />
<p>On August 8th, 2012, 4:19 p.m., Tobias Franz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Tobias Franz.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2012, 4:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">goes back to: https://bugs.kde.org/show_bug.cgi?id=165792
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165792">165792</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(50826a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105932/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic