[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Improve ProgressBar display
From: "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date: 2012-08-15 23:55:00
Message-ID: 20120815235500.19077.49171 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 15, 2012, 11:34 p.m., David Edmundson wrote:
> > plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml, line 139
> > <http://git.reviewboard.kde.org/r/105966/diff/3/?file=76993#file76993line139>
> >
> > You've kept the trigger for width changing, but not height.
> >
> > That doesn't sound right.
You were correct, I've already fixed it.
It's not very important because the progressbar is rotated, but it's good to have it \
nevertheless. Thanks!
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105966/#review17495
-----------------------------------------------------------
On Aug. 10, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105966/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 4:12 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Fix sizing and look of the ProgressBar.
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml 67805ca
>
> Diff: http://git.reviewboard.kde.org/r/105966/diff/
>
>
> Testing
> -------
>
> kde:scratch/apol/kdeqmlviewer + http://proli.net/meu/kde/testprogress.qml
>
>
> Screenshots
> -----------
>
> before
> http://git.reviewboard.kde.org/r/105966/s/669/
> after
> http://git.reviewboard.kde.org/r/105966/s/671/
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105966/">http://git.reviewboard.kde.org/r/105966/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 15th, 2012, 11:34 p.m., <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105966/diff/3/?file=76993#file76993line139" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">139</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> onHeightChanged: \
resizeTimer.restart()</pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You've kept the \
trigger for width changing, but not height.
That doesn't sound right.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You were \
correct, I've already fixed it.
It's not very important because the progressbar is rotated, but it's good to \
have it nevertheless. Thanks!</pre> <br />
<p>- Aleix</p>
<br />
<p>On August 10th, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2012, 4:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix sizing and look of the ProgressBar.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kde:scratch/apol/kdeqmlviewer + \
http://proli.net/meu/kde/testprogress.qml</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/ProgressBar.qml <span \
style="color: grey">(67805ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105966/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105966/s/669/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/10/plasma-progressbar_400x100.png" \
style="border: 1px black solid;" alt="before" /></a>
<a href="http://git.reviewboard.kde.org/r/105966/s/671/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/10/plasma-progressbar2_400x100.png" \
style="border: 1px black solid;" alt="after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic