'Re: Review Request: Dolphin reports open locations to the activity manager'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Dolphin reports open locations to the activity manager
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-15 6:25:57
Message-ID: 20120815062557.16330.72314 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105973/#review17426
-----------------------------------------------------------

This review has been submitted with commit 50d9937eadf9306d03bb5791c43bd226=
1e119791 by Ivan =C4=8Cuki=C4=87 to branch master.

- Commit Hook

On Aug. 11, 2012, 10:27 a.m., Ivan =C4=8Cuki=C4=87 wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105973/
> -----------------------------------------------------------
> =

> (Updated Aug. 11, 2012, 10:27 a.m.)
> =

> =

> Review request for Dolphin, KDE Base Apps, Plasma, and Frank Reininghaus.
> =

> =

> Description
> -------
> =

> Dolphin reports open locations to the activity manager (KAMD).
> =

> Reasoning behind the feature:
>  - KAMD ranks the locations based on the time the user has spent in them
>  - Share-Like-Connect applet can know what is open in dolphin
> =

> This is an compile-time-optional feature - turned on if there is libkacti=
vities installed.
> =

> The find_package(KActivities) is located in the root CMakeLists.txt becau=
se this feature should also be implemented for Konqueror.
> =

> =

> Diffs
> -----
> =

>   dolphin/src/dolphinviewcontainer.cpp 31c82d6 =

>   dolphin/src/dolphinviewcontainer.h fd52806 =

>   CMakeLists.txt fab73c1 =

>   config-apps.h.cmake 43764ef =

>   dolphin/src/CMakeLists.txt 5c1a6da =

> =

> Diff: http://git.reviewboard.kde.org/r/105973/diff/
> =

> =

> Testing
> -------
> =

> With SDI windows, with tabs.
> =

> =

> Screenshots
> -----------
> =

> S-L-C showing dolphin folder
>   http://git.reviewboard.kde.org/r/105973/s/672/
> =

> =

> Thanks,
> =

> Ivan =C4=8Cuki=C4=87
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105973/">http://git.reviewboard.kde.org/r/105973/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 50d9937eadf9306d03bb5791c43bd2261e119791 by Ivan Čukić to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 11th, 2012, 10:27 a.m., Ivan Čukić wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Dolphin, KDE Base Apps, Plasma, and Frank Reininghaus.</div>
<div>By Ivan Čukić.</div>

<p style="color: grey;"><i>Updated Aug. 11, 2012, 10:27 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dolphin reports open locations to the activity manager (KAMD).

Reasoning behind the feature:
 - KAMD ranks the locations based on the time the user has spent in them
 - Share-Like-Connect applet can know what is open in dolphin

This is an compile-time-optional feature - turned on if there is libkactivities \
installed.

The find_package(KActivities) is located in the root CMakeLists.txt because this \
feature should also be implemented for Konqueror. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With SDI windows, with tabs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(31c82d6)</span></li>

 <li>dolphin/src/dolphinviewcontainer.h <span style="color: \
grey">(fd52806)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(fab73c1)</span></li>

 <li>config-apps.h.cmake <span style="color: grey">(43764ef)</span></li>

 <li>dolphin/src/CMakeLists.txt <span style="color: grey">(5c1a6da)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105973/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/105973/s/672/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/10/dolphin-slc_400x100.jpg" \
style="border: 1px black solid;" alt="S-L-C showing dolphin folder" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 