[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Add QML Aurorae decoration support to the startpage
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-08-13 19:20:49
Message-ID: 20120813192049.11824.34751 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105773/#review17336
-----------------------------------------------------------
the template won't work. It's from the KCM to render an Aurorae theme, but =
it's NOT anything to write a window decoration. I would suggest to derive a=
template from the Plastik port once it is finished. =
- Martin Gr=C3=A4=C3=9Flin
On July 28, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105773/
> -----------------------------------------------------------
> =
> (Updated July 28, 2012, 4:50 p.m.)
> =
> =
> Review request for kwin, Plasma, Sebastian K=C3=BCgler, Aaron J. Seigo, a=
nd Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> Hello,
> =
> With this patch i am adding the QML Aurorae decoration support to the sta=
rtpage.
> Now the plasmate has a new entry on the startpage with name "KWin Decorat=
ion".
> Also it provides a new Aurorae decoration template with every new project.
> =
> @Martin The template doesn't simulate switching from active to inactive, =
clicking buttons etc etc. I will add that support among with the previewer.
> @Martin Please take a look at the inline comments...
> @ALL i have change the way that the values from the template ($AUTHOR,$EM=
AIL,$DATE etc) are being changed. What did you think? Did you find any issu=
e?
> =
> =
> Diffs
> -----
> =
> editors/metadata/metadataeditor.cpp 7dffc23 =
> mainwindow.cpp 1f1f28c =
> startpage.h 30b2845 =
> startpage.cpp 726e43a =
> templates/CMakeLists.txt d7acc81 =
> templates/qml/aurorae/AuroraeDecoration.qml PRE-CREATION =
> templates/qml/aurorae/AuroraePreview.qml PRE-CREATION =
> templates/qml/aurorae/DecorationPreview.qml PRE-CREATION =
> templates/qml/aurorae/mainKWinDecoration.qml PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/105773/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105773/">http://git.reviewboard.kde.org/r/105773/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the template won't \
work. It's from the KCM to render an Aurorae theme, but it's NOT anything to \
write a window decoration. I would suggest to derive a template from the Plastik port \
once it is finished. </pre> <br />
<p>- Martin</p>
<br />
<p>On July 28th, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Sebastian Kügler, Aaron J. Seigo, and Martin \
Gräßlin.</div> <div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 28, 2012, 4:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
With this patch i am adding the QML Aurorae decoration support to the startpage.
Now the plasmate has a new entry on the startpage with name "KWin \
Decoration". Also it provides a new Aurorae decoration template with every new \
project.
@Martin The template doesn't simulate switching from active to inactive, clicking \
buttons etc etc. I will add that support among with the previewer. @Martin Please \
take a look at the inline comments... @ALL i have change the way that the values from \
the template ($AUTHOR,$EMAIL,$DATE etc) are being changed. What did you think? Did \
you find any issue? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(7dffc23)</span></li>
<li>mainwindow.cpp <span style="color: grey">(1f1f28c)</span></li>
<li>startpage.h <span style="color: grey">(30b2845)</span></li>
<li>startpage.cpp <span style="color: grey">(726e43a)</span></li>
<li>templates/CMakeLists.txt <span style="color: grey">(d7acc81)</span></li>
<li>templates/qml/aurorae/AuroraeDecoration.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>templates/qml/aurorae/AuroraePreview.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>templates/qml/aurorae/DecorationPreview.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>templates/qml/aurorae/mainKWinDecoration.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105773/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic