[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Nepomuk2 port of Kactivities
From: Ivan Čukić <ivan.cukic () kde ! org>
Date: 2012-08-11 6:43:21
Message-ID: 20120811064321.7782.74534 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105790/#review17231
-----------------------------------------------------------
If I see it correctly, it is mostly a namespace change (and the old nepomuk namespace \
is not used anymore), with two other changes so far?
If so, I'd rather go for something like
namespace Nepomuk = Nepomuk2;
and leave the rest of the code as-is.
This would remove the necessity to have all these changes again when (in KF5) the \
namespace is changed again.
- Ivan Čukić
On July 30, 2012, 12:02 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105790/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 12:02 p.m.)
>
>
> Review request for Plasma and Ivan Čukić.
>
>
> Description
> -------
>
> this is the diff from master of the branch mart/nepomuk2 in kactivities (the branch \
> has a more comprehensible history of changes ;). it ports all the nepomuk usage to \
> nepomuk2
>
> Diffs
> -----
>
> src/service/CMakeLists.txt f6d7f9c
> src/service/NepomukActivityManager.h ba6e75b
> src/service/NepomukActivityManager.cpp e06ded3
> src/service/jobs/nepomuk/Move.h 23db0b7
> src/service/jobs/nepomuk/Move.cpp 8342aef
> src/service/plugins/sqlite/CMakeLists.txt 1664630
> src/service/plugins/sqlite/NepomukCommon.h c3ecacf
> src/workspace/CMakeLists.txt 2fcd194
> src/workspace/kio/CMakeLists.txt 7dfb50c
> src/workspace/kio/kio_activities.cpp 8ef1f7b
>
> Diff: http://git.reviewboard.kde.org/r/105790/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105790/">http://git.reviewboard.kde.org/r/105790/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I see it correctly, \
it is mostly a namespace change (and the old nepomuk namespace is not used anymore), \
with two other changes so far?
If so, I'd rather go for something like
namespace Nepomuk = Nepomuk2;
and leave the rest of the code as-is.
This would remove the necessity to have all these changes again when (in KF5) the \
namespace is changed again.</pre> <br />
<p>- Ivan</p>
<br />
<p>On July 30th, 2012, 12:02 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 30, 2012, 12:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is the diff from master of the branch mart/nepomuk2 in kactivities \
(the branch has a more comprehensible history of changes ;). it ports all the nepomuk \
usage to nepomuk2</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/service/CMakeLists.txt <span style="color: grey">(f6d7f9c)</span></li>
<li>src/service/NepomukActivityManager.h <span style="color: \
grey">(ba6e75b)</span></li>
<li>src/service/NepomukActivityManager.cpp <span style="color: \
grey">(e06ded3)</span></li>
<li>src/service/jobs/nepomuk/Move.h <span style="color: grey">(23db0b7)</span></li>
<li>src/service/jobs/nepomuk/Move.cpp <span style="color: \
grey">(8342aef)</span></li>
<li>src/service/plugins/sqlite/CMakeLists.txt <span style="color: \
grey">(1664630)</span></li>
<li>src/service/plugins/sqlite/NepomukCommon.h <span style="color: \
grey">(c3ecacf)</span></li>
<li>src/workspace/CMakeLists.txt <span style="color: grey">(2fcd194)</span></li>
<li>src/workspace/kio/CMakeLists.txt <span style="color: grey">(7dfb50c)</span></li>
<li>src/workspace/kio/kio_activities.cpp <span style="color: \
grey">(8ef1f7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105790/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic