[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make the Nepomuk runner forward all the nie:urls
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2012-07-30 18:23:18
Message-ID: 20120730182318.25097.15725 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 27, 2012, 11:46 a.m., Torgny Nyblom wrote:
> > My vote is for ship it but it is Albert who is doing the release and he is away \
> > for a few days more. Perhaps better wait for him.
>
> Albert Astals Cid wrote:
> To be honest this looks like a long running bug (reported during 4.8 beta 1?), so i \
> don't see why it's critical to get it in, though i'm open to explanations of why we \
> really need to include it.
> Vishesh Handa wrote:
> I thought the tarballs had not been spun.
>
> Since they have been spun, we can ignore this. It can go in 4.9.1.
Awesome, let's do the same than with the other request (close to get it off the queue \
and commit on wednesday after the release)
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105738/#review16520
-----------------------------------------------------------
On July 26, 2012, 5:25 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105738/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:25 p.m.)
>
>
> Review request for Nepomuk, Plasma, Release Team, and Sebastian Trueg.
>
>
> Description
> -------
>
> Not just the ones that are local files. This fixes opening of emails,
> and other akonadi resources directly from the runner.
>
> @Release Team: It would be nice to have in 4.9 :)
>
>
> This addresses bug 287470.
> http://bugs.kde.org/show_bug.cgi?id=287470
>
>
> Diffs
> -----
>
> plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 0ea308d
>
> Diff: http://git.reviewboard.kde.org/r/105738/diff/
>
>
> Testing
> -------
>
> Yup. Emails open up with KMail.
>
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105738/">http://git.reviewboard.kde.org/r/105738/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 27th, 2012, 11:46 a.m., <b>Torgny \
Nyblom</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">My vote is for ship it but it is Albert who is doing the release and he \
is away for a few days more. Perhaps better wait for him.</pre>
</blockquote>
<p>On July 30th, 2012, 6:08 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest this looks \
like a long running bug (reported during 4.8 beta 1?), so i don't see why \
it's critical to get it in, though i'm open to explanations of why we really \
need to include it.</pre> </blockquote>
<p>On July 30th, 2012, 6:12 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought the tarballs \
had not been spun.
Since they have been spun, we can ignore this. It can go in 4.9.1.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Awesome, let's do \
the same than with the other request (close to get it off the queue and commit on \
wednesday after the release)</pre> <br />
<p>- Albert</p>
<br />
<p>On July 26th, 2012, 5:25 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Plasma, Release Team, and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 26, 2012, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not just the ones that are local files. This fixes opening of emails, \
and other akonadi resources directly from the runner.
@Release Team: It would be nice to have in 4.9 :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yup. Emails open up with KMail.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287470">287470</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp <span style="color: \
grey">(0ea308d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105738/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic