From kde-panel-devel Sat Jul 28 18:28:25 2012 From: "Shaun Reich" Date: Sat, 28 Jul 2012 18:28:25 +0000 To: kde-panel-devel Subject: Re: Review Request: add keyboard nav to konsoleprofiles widget Message-Id: <20120728182825.24333.30405 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134359471211505 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8235491489500685714==" --===============8235491489500685714== Content-Type: multipart/alternative; boundary="===============8138944972328831311==" --===============8138944972328831311== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On July 28, 2012, 4:06 p.m., Shaun Reich wrote: > > Ship It! > = > Shaun Reich wrote: > Looks good. Think you could also propagate this to the Kate and Konso= le widgets? > = > Greg T wrote: > I can also add this to konqprofiles. I don't know what konsole widget= s you are referring to. Oops. I meant the Kate widget as well as the KDevelop widget. = - Shaun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 ----------------------------------------------------------- On July 28, 2012, 11:24 a.m., Greg T wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105765/ > ----------------------------------------------------------- > = > (Updated July 28, 2012, 11:24 a.m.) > = > = > Review request for Plasma and Shaun Reich. > = > = > Description > ------- > = > adds keyboard navigation. up/down arrow key to select item, Enter to open= it > = > = > This addresses bug 303297. > http://bugs.kde.org/show_bug.cgi?id=3D303297 > = > = > Diffs > ----- > = > applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c7692= 7208a40c586a93e60a7c1b71ffc4e23b8 = > = > Diff: http://git.reviewboard.kde.org/r/105765/diff/ > = > = > Testing > ------- > = > tested in a panel > = > = > Thanks, > = > Greg T > = > --===============8138944972328831311== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105765/

On July 28th, 2012, 4:06 p.m., Shaun Reich<= /b> wrote:

Ship It!<=
/pre>

On July 28th, 2012, 4:08 p.m., Shaun Reich wrote:

Looks goo=
d. Think you could also propagate this to the Kate and Konsole widgets?

On July 28th, 2012, 4:34 p.m., Greg T wrote:

I can als=
o add this to konqprofiles. I don't know what konsole widgets you are r=
eferring to.
Oops. I mea=
nt the Kate widget as well as the KDevelop widget.

- Shaun


On July 28th, 2012, 11:24 a.m., Greg T wrote:

Review request for Plasma and Shaun Reich.
By Greg T.

Updated July 28, 2012, 11:24 a.m.

Descripti= on 

adds keyboard navigation. up/down arrow key to select item, =
Enter to open it

Testing <= /h1> 
tested in a panel
Bugs: 303297

Diffs=

  • applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml (c4c76927208a40c586a93e60a7c1b71ffc4e23b8)

View Diff
--===============8138944972328831311==-- --===============8235491489500685714== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8235491489500685714==--