'Re: Review Request: add keyboard nav to konsoleprofiles widget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: add keyboard nav to konsoleprofiles widget
From:       "Shaun Reich" <shaun.reich () kdemail ! net>
Date:       2012-07-28 16:06:08
Message-ID: 20120728160608.14471.34344 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105765/#review16571
-----------------------------------------------------------

Ship it!

Ship It!

- Shaun Reich

On July 28, 2012, 11:24 a.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105765/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 11:24 a.m.)
> 
> 
> Review request for Plasma and Shaun Reich.
> 
> 
> Description
> -------
> 
> adds keyboard navigation. up/down arrow key to select item, Enter to open it
> 
> 
> This addresses bug 303297.
> http://bugs.kde.org/show_bug.cgi?id=303297
> 
> 
> Diffs
> -----
> 
> applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml \
> c4c76927208a40c586a93e60a7c1b71ffc4e23b8  
> Diff: http://git.reviewboard.kde.org/r/105765/diff/
> 
> 
> Testing
> -------
> 
> tested in a panel
> 
> 
> Thanks,
> 
> Greg T
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105765/">http://git.reviewboard.kde.org/r/105765/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Shaun</p>

<br />
<p>On July 28th, 2012, 11:24 a.m., Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Shaun Reich.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated July 28, 2012, 11:24 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">adds keyboard navigation. up/down arrow key to select item, Enter to \
open it</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested in a panel</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303297">303297</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml <span \
style="color: grey">(c4c76927208a40c586a93e60a7c1b71ffc4e23b8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105765/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 