[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: plasma calendar - order events and todos by start date
From: "Greg T" <yellowcake- () gmx ! net>
Date: 2012-07-29 13:31:39
Message-ID: 20120729133139.23356.83134 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105779/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
QHash::values returns a list of items in arbitrary order. So I'm using a QMap to sort them by start time.
This addresses bug 291422.
http://bugs.kde.org/show_bug.cgi?id=291422
Diffs
-----
libs/plasmaclock/calendartable.h 8678593
libs/plasmaclock/calendartable.cpp d2b436e
libs/taskmanager/groupmanager.cpp 45c15a9
Diff: http://git.reviewboard.kde.org/r/105779/diff/
Testing
-------
works for me
Thanks,
Greg T
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105779/">http://git.reviewboard.kde.org/r/105779/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QHash::values returns a list of items in arbitrary order. So I'm \
using a QMap to sort them by start time.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works for me</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291422">291422</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/calendartable.h <span style="color: grey">(8678593)</span></li>
<li>libs/plasmaclock/calendartable.cpp <span style="color: \
grey">(d2b436e)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(45c15a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105779/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic