From kde-panel-devel Sun Jul 29 01:47:55 2012 From: "Commit Hook" Date: Sun, 29 Jul 2012 01:47:55 +0000 To: kde-panel-devel Subject: Re: Review Request: Make sure kmenuedit use predictable order for showing "Name" and "Description" b Message-Id: <20120729014755.10010.92738 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134352675429236 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3812752142509790098==" --===============3812752142509790098== Content-Type: multipart/alternative; boundary="===============8505549491293816619==" --===============8505549491293816619== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105769/#review16587 ----------------------------------------------------------- This review has been submitted with commit 440c1a8b2f3332dcd184a3d463c732f1= 36c4b7b8 by Jekyll Wu to branch master. - Commit Hook On July 28, 2012, 1:11 p.m., Jekyll Wu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105769/ > ----------------------------------------------------------- > = > (Updated July 28, 2012, 1:11 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > The cause is simple: two flags m_detailedMenuEntries and m_detailedEntrie= sNamesFirst are never explicitly initialized. So their values are random, a= nd the final results are unpredictable. = > = > The patch simply initializes both as true, since that seems to be the def= ault behavior of kickoff. > = > = > The git history shows those two flags seem to be something left over from= the KDE3 era. Maybe they should just be removed from the code. However, I'= m not familiar with the code and the history, so this simple patch should b= e safe choice. > = > = > This addresses bug 304177. > http://bugs.kde.org/show_bug.cgi?id=3D304177 > = > = > Diffs > ----- > = > kmenuedit/treeview.cpp 54feff7 = > = > Diff: http://git.reviewboard.kde.org/r/105769/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Jekyll Wu > = > --===============8505549491293816619== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105769/

This revie=
w has been submitted with commit 440c1a8b2f3332dcd184a3d463c732f136c4b7b8 b=
y Jekyll Wu to branch master.

- Commit

On July 28th, 2012, 1:11 p.m., Jekyll Wu wrote:

Review request for Plasma.

By Jekyll Wu.

Updated July 28, 2012, 1:11 p.m.

Descripti= on

The cause is simple: two flags m_detailedMenuEntries and m_d=
etailedEntriesNamesFirst are never explicitly initialized. So their values =
are random, and the final results are unpredictable. =


The patch simply initializes both as true, since that seems to be the defau=
lt behavior of kickoff.


The git history shows those two flags seem to be something left over from t=
he KDE3 era. Maybe they should just be removed from the code. However, I=
9;m not familiar with the code and the history, so this simple patch should=
 be safe choice.

Bugs: 304177

Diffs=

kmenuedit/treeview.cpp (54feff7)

View Diff

--===============8505549491293816619==-- --===============3812752142509790098== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3812752142509790098==--