--===============5138947408190643290== Content-Type: multipart/alternative; boundary="===============9141016902913398701==" --===============9141016902913398701== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105773/#review16579 ----------------------------------------------------------- startpage.cpp Should we change it to "Window Decoration"? startpage.cpp Since the kcm_kwindecoration is using the "xorg" icon, i thought that a= lso the plasmate should use it. What do you think? startpage.cpp A new file, with the name of the project is being copied inside the $Pr= ojectName/contents/code.... And i cannot find why... The files that are sup= posed to be copied are the qml/aurorae - Antonis Tsiapaliokas On July 28, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105773/ > ----------------------------------------------------------- > = > (Updated July 28, 2012, 4:50 p.m.) > = > = > Review request for kwin, Plasma, Sebastian K=C3=BCgler, Aaron J. Seigo, a= nd Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > Hello, > = > With this patch i am adding the QML Aurorae decoration support to the sta= rtpage. > Now the plasmate has a new entry on the startpage with name "KWin Decorat= ion". > Also it provides a new Aurorae decoration template with every new project. > = > @Martin The template doesn't simulate switching from active to inactive, = clicking buttons etc etc. I will add that support among with the previewer. > @Martin Please take a look at the inline comments... > @ALL i have change the way that the values from the template ($AUTHOR,$EM= AIL,$DATE etc) are being changed. What did you think? Did you find any issu= e? > = > = > Diffs > ----- > = > editors/metadata/metadataeditor.cpp 7dffc23 = > mainwindow.cpp 1f1f28c = > startpage.h 30b2845 = > startpage.cpp 726e43a = > templates/CMakeLists.txt d7acc81 = > templates/qml/aurorae/AuroraeDecoration.qml PRE-CREATION = > templates/qml/aurorae/AuroraePreview.qml PRE-CREATION = > templates/qml/aurorae/DecorationPreview.qml PRE-CREATION = > templates/qml/aurorae/mainKWinDecoration.qml PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/105773/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Antonis Tsiapaliokas > = > --===============9141016902913398701== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105773/

= =

startpage.cpp (Diff revision 1)
void StartPage::setupWidgets()
		148	new QListWidgetItem(KI= con("xorg"), i18n("KWin Decoration"), m_ui.contentTypes);

Should we change it to "Window Decoration"?

= =

startpage.cpp (Diff revision 1)
void StartPage::refreshRecentProjectsList()
		350	defaultIconName<= /span> =3D "xorg";

Since the kcm_kwindecoration is using the "xorg" icon, i t=
hought that also the plasmate should use it. What do you think?

= =

startpage.cpp (Diff revision 1)
void StartPage::createNewProject()
		472	tmpFile.copy= (projectPath + "/contents/code/" +fileName);

A new file, with the name of the project is being copied inside the =
$ProjectName/contents/code.... And i cannot find why... The files that are =
supposed to be copied are the qml/aurorae

- Antonis

On July 28th, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote:

Review request for kwin, Plasma, Sebastian K=C3=BCgler, Aaron J. Seigo= , and Martin Gr=C3=A4=C3=9Flin.

By Antonis Tsiapaliokas.

Updated July 28, 2012, 4:50 p.m.

Descripti= on

Hello,

With this patch i am adding the QML Aurorae decoration support to the start=
page.
Now the plasmate has a new entry on the startpage with name "KWin Deco=
ration".
Also it provides a new Aurorae decoration template with every new project.

@Martin The template doesn't simulate switching from active to inactive=
, clicking buttons etc etc. I will add that support among with the previewe=
r.
@Martin Please take a look at the inline comments...
@ALL i have change the way that the values from the template ($AUTHOR,$EMAI=
L,$DATE etc) are being changed. What did you think? Did you find any issue?

Diffs=

editors/metadata/metadataeditor.cpp (7dffc= 23)
mainwindow.cpp (1f1f28c)
startpage.h (30b2845)
startpage.cpp (726e43a)
templates/CMakeLists.txt (d7acc81)<= /li>
templates/qml/aurorae/AuroraeDecoration.qml (= PRE-CREATION)
templates/qml/aurorae/DecorationPreview.qml (PRE-CREATION)

--===============9141016902913398701==-- --===============5138947408190643290== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5138947408190643290==--