This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105773/

startpage.cpp (Diff revision 1)
void StartPage::setupWidgets()
148
    new QListWidgetItem(KIcon("xorg"), i18n("KWin Decoration"), m_ui.contentTypes);
Should we change it to "Window Decoration"?

startpage.cpp (Diff revision 1)
void StartPage::refreshRecentProjectsList()
350
            defaultIconName = "xorg";
Since the kcm_kwindecoration is using the "xorg" icon, i thought that also the plasmate should use it. What do you think?

startpage.cpp (Diff revision 1)
void StartPage::createNewProject()
472
                tmpFile.copy(projectPath + "/contents/code/" +fileName);
A new file, with the name of the project is being copied inside the $ProjectName/contents/code.... And i cannot find why... The files that are supposed to be copied are the qml/aurorae

- Antonis


On July 28th, 2012, 4:50 p.m., Antonis Tsiapaliokas wrote:

Review request for kwin, Plasma, Sebastian Kügler, Aaron J. Seigo, and Martin Gräßlin.
By Antonis Tsiapaliokas.

Updated July 28, 2012, 4:50 p.m.

Description

Hello,

With this patch i am adding the QML Aurorae decoration support to the startpage.
Now the plasmate has a new entry on the startpage with name "KWin Decoration".
Also it provides a new Aurorae decoration template with every new project.

@Martin The template doesn't simulate switching from active to inactive, clicking buttons etc etc. I will add that support among with the previewer.
@Martin Please take a look at the inline comments...
@ALL i have change the way that the values from the template ($AUTHOR,$EMAIL,$DATE etc) are being changed. What did you think? Did you find any issue?

Diffs

  • editors/metadata/metadataeditor.cpp (7dffc23)
  • mainwindow.cpp (1f1f28c)
  • startpage.h (30b2845)
  • startpage.cpp (726e43a)
  • templates/CMakeLists.txt (d7acc81)
  • templates/qml/aurorae/AuroraeDecoration.qml (PRE-CREATION)
  • templates/qml/aurorae/AuroraePreview.qml (PRE-CREATION)
  • templates/qml/aurorae/DecorationPreview.qml (PRE-CREATION)
  • templates/qml/aurorae/mainKWinDecoration.qml (PRE-CREATION)

View Diff