'Re: Review Request: increased binary clock applet minimum size'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: increased binary clock applet minimum size
From:       "Reza Shah" <rshah0385 () kireihana ! com>
Date:       2012-07-28 2:33:27
Message-ID: 20120728023327.20277.2281 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On July 27, 2012, 9:17 p.m., Ben Cooksley wrote:
> > Has this been committed to master as well?

Yes,
http://commits.kde.org/kdeplasma-addons/a333b14dac7323f5a84d79835548c11ae067667f

- Reza

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105577/#review16554
-----------------------------------------------------------

On July 15, 2012, 12:19 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105577/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 12:19 p.m.)
> 
> 
> Review request for Plasma and Davide Bettio.
> 
> 
> Description
> -------
> 
> bug reference: https://bugs.kde.org/show_bug.cgi?id=301674
> using previous minimum size the applet drawn incorrectly.
> this patch slightly increased the minimum size of binary clock applet when placed in desktop.
> 
> 
> This addresses bug 301674.
>     http://bugs.kde.org/show_bug.cgi?id=301674
> 
> 
> Diffs
> -----
> 
>   applets/binary-clock/binaryclock.cpp 6e706de 
> 
> Diff: http://git.reviewboard.kde.org/r/105577/diff/
> 
> 
> Testing
> -------
> 
> master
> 
> 
> Screenshots
> -----------
> 
> before - after
>   http://git.reviewboard.kde.org/r/105577/s/637/
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105577/">http://git.reviewboard.kde.org/r/105577/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 27th, 2012, 9:17 p.m., <b>Ben Cooksley</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this \
been committed to master as well?</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, \
http://commits.kde.org/kdeplasma-addons/a333b14dac7323f5a84d79835548c11ae067667f</pre>
 <br />

<p>- Reza</p>

<br />
<p>On July 15th, 2012, 12:19 p.m., Reza Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Davide Bettio.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated July 15, 2012, 12:19 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">bug reference: https://bugs.kde.org/show_bug.cgi?id=301674 using \
previous minimum size the applet drawn incorrectly. this patch slightly increased the \
minimum size of binary clock applet when placed in desktop.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">master</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=301674">301674</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/binary-clock/binaryclock.cpp <span style="color: \
grey">(6e706de)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105577/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/105577/s/637/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/15/binaryclockbefore_after_400x100.png" \
style="border: 1px black solid;" alt="before - after" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 