--===============8491380262329475172== Content-Type: multipart/alternative; boundary="===============2081046455915385296==" --===============2081046455915385296== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review16476 ----------------------------------------------------------- what i can say quickly looking at it is that it looks cleaner and more expa= ndible than the old one. of course is a bit big, so will indeed need more testing, but most importan= t thing for the first merge is that there aren't significant regressions co= mpared to what there is already (konq, firefox, opera) - Marco Martin On July 26, 2012, 10:23 a.m., Marco Gulino wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105673/ > ----------------------------------------------------------- > = > (Updated July 26, 2012, 10:23 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > I've nearly finished my work on the Bookmarks krunner, at least I think i= t's ready for a review. > Main focus: add support for chrome (and chromium). > Side effects: refactoring, a few unit tests, and Favicons for firefox (it= 's very similar for chrome, they're stored as sqlite blob, so adding favico= n for chrome meant making easy to add them to firefox too). > I also removed some code seeming dead, or duplicated. > = > I'm mostly unhappy with the favicon fetch from firefox and chrome: i had = to save them to temp file since it's impossible to load QPixmap in krunner = plugins. > = > What's still missing: maybe a little more testing (both unit and manual) = and cleanup. > = > branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runner= s/bookmarks > = > = > Diffs > ----- > = > plasma/generic/runners/bookmarks/.gitignore PRE-CREATION = > plasma/generic/runners/bookmarks/CMakeLists.txt 39d7834 = > plasma/generic/runners/bookmarks/bookmarkmatch.h PRE-CREATION = > plasma/generic/runners/bookmarks/bookmarkmatch.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/bookmarksrunner.h d7545af = > plasma/generic/runners/bookmarks/bookmarksrunner.cpp aa3d45d = > plasma/generic/runners/bookmarks/bookmarksrunner_defs.h PRE-CREATION = > plasma/generic/runners/bookmarks/browser.h PRE-CREATION = > plasma/generic/runners/bookmarks/browserfactory.h PRE-CREATION = > plasma/generic/runners/bookmarks/browserfactory.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/chrome.h PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/chrome.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/chromefindprofile.h PRE-CREAT= ION = > plasma/generic/runners/bookmarks/browsers/chromefindprofile.cpp PRE-CRE= ATION = > plasma/generic/runners/bookmarks/browsers/findprofile.h PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/firefox.h PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/firefox.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/kdebrowser.h PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/kdebrowser.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/opera.h PRE-CREATION = > plasma/generic/runners/bookmarks/browsers/opera.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/favicon.h PRE-CREATION = > plasma/generic/runners/bookmarks/favicon.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/faviconfromblob.h PRE-CREATION = > plasma/generic/runners/bookmarks/faviconfromblob.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/fetchsqlite.h PRE-CREATION = > plasma/generic/runners/bookmarks/fetchsqlite.cpp PRE-CREATION = > plasma/generic/runners/bookmarks/plasma-runner-bookmarks.desktop b75259= 1 = > plasma/generic/runners/bookmarks/tests/CMakeLists.txt PRE-CREATION = > plasma/generic/runners/bookmarks/tests/chrome-config-home/.config/chrom= ium/Local PRE-CREATION = > plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookma= rks-Sample.json PRE-CREATION = > plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookma= rks-SecondProfile.json PRE-CREATION = > plasma/generic/runners/bookmarks/tests/testchromebookmarks.h PRE-CREATI= ON = > plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp PRE-CREA= TION = > = > Diff: http://git.reviewboard.kde.org/r/105673/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Marco Gulino > = > --===============2081046455915385296== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105673/ |
what i can= say quickly looking at it is that it looks cleaner and more expandible tha= n the old one. of course is a bit big, so will indeed need more testing, but most importan= t thing for the first merge is that there aren't significant regression= s compared to what there is already (konq, firefox, opera)
- Marco
On July 26th, 2012, 10:23 a.m., Marco Gulino wrote:
Review request for Plasma.
By Marco Gulino.
Updated July 26, 2012, 10:23 a.m. Descripti= on
Diffs=
|