From kde-panel-devel Thu Jul 26 10:34:06 2012 From: "Marco Martin" Date: Thu, 26 Jul 2012 10:34:06 +0000 To: kde-panel-devel Subject: Re: Review Request: Add missing email addresses back into add widget tooltip. Message-Id: <20120726103406.8087.28959 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134329913124190 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2539989185351831330==" --===============2539989185351831330== Content-Type: multipart/alternative; boundary="===============7176752135683008019==" --===============7176752135683008019== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105312/#review16475 ----------------------------------------------------------- this was partly committed. what's still missing in master is the clickable email. - Marco Martin On June 21, 2012, 4:39 a.m., Matthew John Dawson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105312/ > ----------------------------------------------------------- > = > (Updated June 21, 2012, 4:39 a.m.) > = > = > Review request for Plasma, Ivan =C4=8Cuki=C4=87 and Marco Martin. > = > = > Description > ------- > = > When the QML port of the add widget dialog occured, the creator's email a= ddress got chopped off. This commit fixes a bug hidding the email address,= and also starts displaying it again in the tooltip. > = > There are a couple of issue left with this patch: > 1) I have to disable wrapping, otherwise the text wraps at odd points for= no reason (it fits fine otherwise). > 2) The link currently doesn't work as I'm not sure how to hook it up to s= end mail. Should it be left as is, or just remove the link for 4.9 and upd= ate with a link for 4.10? > = > = > Diffs > ----- > = > libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml= ba804fd006496ee4a7118e97fe44038f0617eec7 = > libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h e745e= f58533ab0e22d2109d5beeff6c29c4d18b4 = > = > Diff: http://git.reviewboard.kde.org/r/105312/diff/ > = > = > Testing > ------- > = > Tested locally in Xephyr. The tooltip now contains the email address. > = > = > Thanks, > = > Matthew John Dawson > = > --===============7176752135683008019== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105312/ 

this was p=
artly committed.
what's still missing in master is the clickable email.

- Marco


On June 21st, 2012, 4:39 a.m., Matthew John Dawson wrote:

Review request for Plasma, Ivan =C4=8Cuki=C4=87 and Marco Martin.
By Matthew John Dawson.

Updated June 21, 2012, 4:39 a.m.

Descripti= on 

When the QML port of the add widget dialog occured, the crea=
tor's email address got chopped off.  This commit fixes a bug hidding t=
he email address, and also starts displaying it again in the tooltip.

There are a couple of issue left with this patch:
1) I have to disable wrapping, otherwise the text wraps at odd points for n=
o reason (it fits fine otherwise).
2) The link currently doesn't work as I'm not sure how to hook it u=
p to send mail.  Should it be left as is, or just remove the link for 4.9 a=
nd update with a link for 4.10?

Testing <= /h1> 
Tested locally in Xephyr.  The tooltip now contains the emai=
l address.

Diffs=

  • libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qm= l (ba804fd006496ee4a7118e97fe44038f0617eec7)
  • libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h (e745ef58533ab0e22d2109d5beeff6c29c4d18b4)

View Diff
--===============7176752135683008019==-- --===============2539989185351831330== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2539989185351831330==--