[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support
From: "Marco Gulino" <marco.gulino () gmail ! com>
Date: 2012-07-26 10:23:18
Message-ID: 20120726102318.7306.34466 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/
-----------------------------------------------------------
(Updated July 26, 2012, 10:23 a.m.)
Review request for Plasma.
Description
-------
I've nearly finished my work on the Bookmarks krunner, at least I think it'=
s ready for a review.
Main focus: add support for chrome (and chromium).
Side effects: refactoring, a few unit tests, and Favicons for firefox (it's=
very similar for chrome, they're stored as sqlite blob, so adding favicon =
for chrome meant making easy to add them to firefox too).
I also removed some code seeming dead, or duplicated.
I'm mostly unhappy with the favicon fetch from firefox and chrome: i had to=
save them to temp file since it's impossible to load QPixmap in krunner pl=
ugins.
What's still missing: maybe a little more testing (both unit and manual) an=
d cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runners/=
bookmarks
Diffs (updated)
-----
plasma/generic/runners/bookmarks/.gitignore PRE-CREATION =
plasma/generic/runners/bookmarks/CMakeLists.txt 39d7834 =
plasma/generic/runners/bookmarks/bookmarkmatch.h PRE-CREATION =
plasma/generic/runners/bookmarks/bookmarkmatch.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/bookmarksrunner.h d7545af =
plasma/generic/runners/bookmarks/bookmarksrunner.cpp aa3d45d =
plasma/generic/runners/bookmarks/bookmarksrunner_defs.h PRE-CREATION =
plasma/generic/runners/bookmarks/browser.h PRE-CREATION =
plasma/generic/runners/bookmarks/browserfactory.h PRE-CREATION =
plasma/generic/runners/bookmarks/browserfactory.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/chrome.h PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/chrome.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/chromefindprofile.h PRE-CREATIO=
N =
plasma/generic/runners/bookmarks/browsers/chromefindprofile.cpp PRE-CREAT=
ION =
plasma/generic/runners/bookmarks/browsers/findprofile.h PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/firefox.h PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/firefox.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/kdebrowser.h PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/kdebrowser.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/opera.h PRE-CREATION =
plasma/generic/runners/bookmarks/browsers/opera.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/favicon.h PRE-CREATION =
plasma/generic/runners/bookmarks/favicon.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/faviconfromblob.h PRE-CREATION =
plasma/generic/runners/bookmarks/faviconfromblob.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/fetchsqlite.h PRE-CREATION =
plasma/generic/runners/bookmarks/fetchsqlite.cpp PRE-CREATION =
plasma/generic/runners/bookmarks/plasma-runner-bookmarks.desktop b752591 =
plasma/generic/runners/bookmarks/tests/CMakeLists.txt PRE-CREATION =
plasma/generic/runners/bookmarks/tests/chrome-config-home/.config/chromiu=
m/Local PRE-CREATION =
plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmark=
s-Sample.json PRE-CREATION =
plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmark=
s-SecondProfile.json PRE-CREATION =
plasma/generic/runners/bookmarks/tests/testchromebookmarks.h PRE-CREATION =
plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp PRE-CREATI=
ON =
Diff: http://git.reviewboard.kde.org/r/105673/diff/
Testing
-------
Thanks,
Marco Gulino
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105673/">http://git.reviewboard.kde.org/r/105673/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Gulino.</div>
<p style="color: grey;"><i>Updated July 26, 2012, 10:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've nearly finished my work on the Bookmarks krunner, at least I \
think it's ready for a review. Main focus: add support for chrome (and chromium).
Side effects: refactoring, a few unit tests, and Favicons for firefox (it's very \
similar for chrome, they're stored as sqlite blob, so adding favicon for chrome \
meant making easy to add them to firefox too). I also removed some code seeming dead, \
or duplicated.
I'm mostly unhappy with the favicon fetch from firefox and chrome: i had to save \
them to temp file since it's impossible to load QPixmap in krunner plugins.
What's still missing: maybe a little more testing (both unit and manual) and \
cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runners/bookmarks
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/bookmarks/.gitignore <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/CMakeLists.txt <span style="color: \
grey">(39d7834)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarkmatch.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarkmatch.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarksrunner.h <span style="color: \
grey">(d7545af)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarksrunner.cpp <span style="color: \
grey">(aa3d45d)</span></li>
<li>plasma/generic/runners/bookmarks/bookmarksrunner_defs.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browser.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browserfactory.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browserfactory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chrome.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chrome.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chromefindprofile.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/chromefindprofile.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/findprofile.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/firefox.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/firefox.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/kdebrowser.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/kdebrowser.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/opera.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/browsers/opera.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/favicon.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/favicon.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/faviconfromblob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/faviconfromblob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/fetchsqlite.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/fetchsqlite.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/plasma-runner-bookmarks.desktop <span \
style="color: grey">(b752591)</span></li>
<li>plasma/generic/runners/bookmarks/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/chrome-config-home/.config/chromium/Local \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/testchromebookmarks.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105673/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic