From kde-panel-devel Thu Jul 26 10:21:35 2012 From: "Marco Martin" Date: Thu, 26 Jul 2012 10:21:35 +0000 To: kde-panel-devel Subject: Re: Review Request: kickoff-qml: TabBar button width Message-Id: <20120726102135.7172.99369 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134329836823925 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2433963884650451703==" --===============2433963884650451703== Content-Type: multipart/alternative; boundary="===============1151708972867101645==" --===============1151708972867101645== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > = > > the changes seems good, but i'm not sure about giving kickoff a copy of= the tabbar. > > = > > any reason this is not proposed as a patch for the tabbar component its= elf? > = > Greg T wrote: > Of course I could do that. But I didn't know if such a general change= would be welcome. Maybe people love equally sized blocks? > = > Marco Martin wrote: > i really think we shouldn't start to customize the components in a si= ngle applet like that. > = > what could be done is: > as implicit width of the tabbar should be a width such that all tabs = have the same width that is the one of the largest tab, so by default it wo= uld attempt to never elide (probably some work in the bindings is needed to= export this as preferred width of the applet). > = > if it's forced to be smaller it starts to elide the text. > = > Greg T wrote: > I'm not sure if I can follow you, but basically you describe the curr= ent behavior. Every TabButton got a 'implicitHeight: label.paintedHeight' a= nd the layout calculates a minimum implicitWidth that doesn't elide text. T= he export is missing, though. basically would be kickoff opening by default wide enough to make all text = fit (maybe still not going over a maximum width) i'm not sure what's still missing in the bindings to make this feasible tou= gh - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16103 ----------------------------------------------------------- On July 1, 2012, 8:42 p.m., Greg T wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105405/ > ----------------------------------------------------------- > = > (Updated July 1, 2012, 8:42 p.m.) > = > = > Review request for Plasma, Marco Martin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > Heda, > This patch addresses the layout of the tab bar. The tab buttons are now s= ized depending of their text width. > = > I just copied the tabbar code from kde-runtime and exchanged taskbarLayou= t. My main question is: Can I do this more elegantly without copying TabBar= .qml? > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PR= E-CREATION = > plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout= .qml PRE-CREATION = > plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 = > = > Diff: http://git.reviewboard.kde.org/r/105405/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Greg T > = > --===============1151708972867101645== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105405/

On July 19th, 2012, 9:04 a.m., Marco Martin= wrote:

thanks, w=
ouldn;t have remembered ;)

the changes seems good, but i'm not sure about giving kickoff a copy of=
 the tabbar.

any reason this is not proposed as a patch for the tabbar component itself?=

On July 19th, 2012, 12:55 p.m., Greg T wrote:

Of course=
 I could do that. But I didn't know if such a general change would be w=
elcome. Maybe people love equally sized blocks?

On July 19th, 2012, 2:23 p.m., Marco Martin wrote:

i really =
think we shouldn't start to customize the components in a single applet=
 like that.

what could be done is:
as implicit width of the tabbar should be a width such that all tabs have t=
he same width that is the one of the largest tab, so by default it would at=
tempt to never elide (probably some work in the bindings is needed to expor=
t this as preferred width of the applet).

if it's forced to be smaller it starts to elide the text.

On July 20th, 2012, 6 p.m., Greg T wrote:

I'm n=
ot sure if I can follow you, but basically you describe the current behavio=
r. Every TabButton got a 'implicitHeight: label.paintedHeight' and =
the layout calculates a minimum implicitWidth that doesn't elide text. =
The export is missing, though.
basically w=
ould be kickoff opening by default wide enough to make all text fit (maybe =
still not going over a maximum width)

i'm not sure what's still missing in the bindings to make this feas=
ible tough

- Marco


On July 1st, 2012, 8:42 p.m., Greg T wrote:

Review request for Plasma, Marco Martin and Martin Gr=C3=A4=C3=9Flin.<= /div>
By Greg T.

Updated July 1, 2012, 8:42 p.m.

Descripti= on 

Heda,
This patch addresses the layout of the tab bar. The tab buttons are now siz=
ed depending of their text width.

I just copied the tabbar code from kde-runtime and exchanged taskbarLayout.=
 My main question is: Can I do this more elegantly without copying TabBar.q=
ml?

Diffs=

  • plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml <= span style=3D"color: grey">(PRE-CREATION)
  • plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayou= t.qml (PRE-CREATION)
  • plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml (4d53208)

View Diff
--===============1151708972867101645==-- --===============2433963884650451703== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2433963884650451703==--