[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add comment to blackboard applet
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-07-26 10:16:07
Message-ID: 20120726101607.6939.81839 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105704/#review16465
-----------------------------------------------------------
the patch doesn't apply cleanly, so is probably to be redone (desktop file changed by \
scripty in the meantime)
however, i'm fine to add a comment in the blackboard applet in the master branch.
- Marco Martin
On July 24, 2012, 4:16 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105704/
> -----------------------------------------------------------
>
> (Updated July 24, 2012, 4:16 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Add a comment (description) to the blackboard applet.
> Feedback welcome.
>
> I do not have commit access. This introduces a new string.
>
>
> This addresses bug 302636.
> http://bugs.kde.org/show_bug.cgi?id=302636
>
>
> Diffs
> -----
>
> applets/blackboard/plasma-applet-blackboard.desktop 298316e
>
> Diff: http://git.reviewboard.kde.org/r/105704/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maarten De Meyer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105704/">http://git.reviewboard.kde.org/r/105704/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the patch doesn't \
apply cleanly, so is probably to be redone (desktop file changed by scripty in the \
meantime)
however, i'm fine to add a comment in the blackboard applet in the master \
branch.</pre> <br />
<p>- Marco</p>
<br />
<p>On July 24th, 2012, 4:16 p.m., Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated July 24, 2012, 4:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a comment (description) to the blackboard applet. Feedback welcome.
I do not have commit access. This introduces a new string.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302636">302636</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/blackboard/plasma-applet-blackboard.desktop <span style="color: \
grey">(298316e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105704/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic