'Re: Review Request: Clean up rtm headers and move private data from Auth and Request classes into pr'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Clean up rtm headers and move private data from Auth and Request classes into pr
From:       "Jeremy Paul Whiting" <jpwhiting () kde ! org>
Date:       2012-07-26 4:55:32
Message-ID: 20120726045532.21798.73024 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105734/
-----------------------------------------------------------

(Updated July 26, 2012, 4:55 a.m.)

Review request for Plasma and Andrew Stromme.

Changes
-------

Added Andrew to reviewers

Description
-------

rtm: Move Request private data into RequestPrivate class in .cpp file. rtm:=
 Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up =
auth.h and request.h files.

rtm: Clean up rtm header files.

Add #include <rtm/task.h> since we use Task * (and session.h has been clean=
ed up).

Diffs
-----

  dataengines/rememberthemilk/taskservice.cpp d738093ffd7c5183cf24f9f932d0c=
7f934b6634b =

  libs/rtm/auth.h 5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1 =

  libs/rtm/auth.cpp 16fd5f0c28004dcc12140556e8d6727c483c2ed9 =

  libs/rtm/note.h af4cfd20c6ddaf1a4943f76f148c79918b5ec633 =

  libs/rtm/request.h d371714c144bf9bc6c7304a861840334f0846cdb =

  libs/rtm/request.cpp 1304cb5d1a547d08b7f82e44cd319097991c8425 =

  libs/rtm/rtm.h 1a542f6007c63df13b79dd60da0cfcfe294f8e16 =

  libs/rtm/session.h aad145c44c70fb28fe1496b93d991667e918f630 =

  libs/rtm/xmlreaders.h b9ea78ca567e32aceb70361a2735b7b005d15777 =

Diff: http://git.reviewboard.kde.org/r/105734/diff/

Testing
-------

It builds and runs ok here (the rtm applet logs in and loads data ok).

Thanks,

Jeremy Paul Whiting

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105734/">http://git.reviewboard.kde.org/r/105734/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Andrew Stromme.</div>
<div>By Jeremy Paul Whiting.</div>

<p style="color: grey;"><i>Updated July 26, 2012, 4:55 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added Andrew to reviewers</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">rtm: Move Request private data into RequestPrivate class in .cpp file. \
rtm: Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up auth.h \
and request.h files.

rtm: Clean up rtm header files.

Add #include &lt;rtm/task.h&gt; since we use Task * (and session.h has been cleaned \
up).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It builds and runs ok here (the rtm applet logs in and loads data \
ok).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dataengines/rememberthemilk/taskservice.cpp <span style="color: \
grey">(d738093ffd7c5183cf24f9f932d0c7f934b6634b)</span></li>

 <li>libs/rtm/auth.h <span style="color: \
grey">(5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1)</span></li>

 <li>libs/rtm/auth.cpp <span style="color: \
grey">(16fd5f0c28004dcc12140556e8d6727c483c2ed9)</span></li>

 <li>libs/rtm/note.h <span style="color: \
grey">(af4cfd20c6ddaf1a4943f76f148c79918b5ec633)</span></li>

 <li>libs/rtm/request.h <span style="color: \
grey">(d371714c144bf9bc6c7304a861840334f0846cdb)</span></li>

 <li>libs/rtm/request.cpp <span style="color: \
grey">(1304cb5d1a547d08b7f82e44cd319097991c8425)</span></li>

 <li>libs/rtm/rtm.h <span style="color: \
grey">(1a542f6007c63df13b79dd60da0cfcfe294f8e16)</span></li>

 <li>libs/rtm/session.h <span style="color: \
grey">(aad145c44c70fb28fe1496b93d991667e918f630)</span></li>

 <li>libs/rtm/xmlreaders.h <span style="color: \
grey">(b9ea78ca567e32aceb70361a2735b7b005d15777)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105734/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 