[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: ksplashx: Adjust erroneous CMake calls.
From: "Commit Hook" <null () kde ! org>
Date: 2012-07-23 3:05:48
Message-ID: 20120723030548.13112.67960 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105468/#review16249
-----------------------------------------------------------
This review has been submitted with commit 7d11d3a09b981201f0bd8c2404f20854=
7331f55c by Raphael Kubo da Costa to branch master.
- Commit Hook
On July 7, 2012, 3:07 a.m., Raphael Kubo da Costa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105468/
> -----------------------------------------------------------
> =
> (Updated July 7, 2012, 3:07 a.m.)
> =
> =
> Review request for Build System and Plasma.
> =
> =
> Description
> -------
> =
> ksplashx: Adjust erroneous CMake calls.
> =
> Since its inception, ksplashx's CMakeLists.txt was using `include(FindFOO=
)'
> instead of `find_package(FOO)' to find libpng and libjpeg. While it has i=
ndeed
> worked so far, it is not the right way to find dependencies.
> =
> Adjust this by correctly looking for libpng and libjpeg via find_package(=
). The
> calls are in the top-level CMakeLists.txt since putting all find_package(=
) and
> macro_optional_find_package() calls in the same file seems to appease some
> packagers.
> =
> While here, also add libjpeg's include directory to the compiler's includ=
e path
> and use a FindPNG variable that's not internal to do the same for libpng.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt ded5a2995b3d25c1c7c891afe93795fb0dfcfb87 =
> ksplash/ksplashx/CMakeLists.txt 65447939dc9ac17c69f1e94afe935b37c7dceba=
4 =
> =
> Diff: http://git.reviewboard.kde.org/r/105468/diff/
> =
> =
> Testing
> -------
> =
> kde-workspace built fine both before and after this change
> =
> =
> Thanks,
> =
> Raphael Kubo da Costa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105468/">http://git.reviewboard.kde.org/r/105468/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7d11d3a09b981201f0bd8c2404f208547331f55c by Raphael Kubo da \
Costa to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 7th, 2012, 3:07 a.m., Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System and Plasma.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated July 7, 2012, 3:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ksplashx: Adjust erroneous CMake calls.
Since its inception, ksplashx's CMakeLists.txt was using `include(FindFOO)'
instead of `find_package(FOO)' to find libpng and libjpeg. While it has indeed
worked so far, it is not the right way to find dependencies.
Adjust this by correctly looking for libpng and libjpeg via find_package(). The
calls are in the top-level CMakeLists.txt since putting all find_package() and
macro_optional_find_package() calls in the same file seems to appease some
packagers.
While here, also add libjpeg's include directory to the compiler's include \
path and use a FindPNG variable that's not internal to do the same for \
libpng.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kde-workspace built fine both before and after this change</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(ded5a2995b3d25c1c7c891afe93795fb0dfcfb87)</span></li>
<li>ksplash/ksplashx/CMakeLists.txt <span style="color: \
grey">(65447939dc9ac17c69f1e94afe935b37c7dceba4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105468/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic